PerfectApp\Container\Container::get()

Complexity

Conditions	10
Paths	11

Size

Total Lines	47
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	11.7434

Importance

Changes

0

<?php declare(strict_types=1);
    public function get(string $className): object
    {
        if (isset($this->bindings[$className])) {
            $concrete = $this->bindings[$className];

            if ($concrete instanceof Closure) {
                return $concrete($this);
            }

            $className = $concrete;
        }

        if (!isset($this->instances[$className])) {
            try {
                $reflectionClass = new ReflectionClass($className);
            } catch (ReflectionException $e) {
                error_log("Failed to create ReflectionClass for $className: {$e->getMessage()}");
                http_response_code(500);
                die('Fatal Error. See Error log for details.');

In this branch, the function will implicitly return null which is incompatible with the type-hinted return object. Consider adding a return statement or allowing null as return value.

Using exit here is not recommended.

            }

            $constructor = $reflectionClass->getConstructor();

            if ($constructor) {
                $params = $constructor->getParameters();
                $dependencies = [];

                foreach ($params as $param) {
                    $type = $param->getType();
                    if ($type && !$type->isBuiltin()) {
                        $dependency = $type->getName();

The method getName() does not exist on ReflectionType. It seems like you code against a sub-type of ReflectionType such as ReflectionNamedType.

                        $dependencies[] = $this->get($dependency);
                    }
                }

                try {
                    $this->instances[$className] = $reflectionClass->newInstanceArgs($dependencies);
                } catch (ReflectionException $e) {
                    error_log("Failed to instantiate $className: {$e->getMessage()}");
                    die('Fatal Error. See Error log for details.');

In this branch, the function will implicitly return null which is incompatible with the type-hinted return object. Consider adding a return statement or allowing null as return value.

Using exit here is not recommended.

                }
            } else {
                $this->instances[$className] = new $className();
            }
        }

        return $this->instances[$className];
    }