AllCommand::handle() - Code Metrics - Inspection of "Merge pull request #15 from ben182/develop" - ben182/laravel-auto-translate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e6963...479a33 )

by Benjamin

created 2019-04-13 10:55 UTC

AllCommand::handle() A

↳ Parent: AllCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	0
cts	15
cp	0
rs	9.552
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php

namespace Ben182\AutoTranslate\Commands;

use Illuminate\Support\Arr;
use Illuminate\Console\Command;
use Ben182\AutoTranslate\AutoTranslate;

class AllCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'autotrans:all';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Translates all source translations to target translations';

    protected $autoTranslator;

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct(AutoTranslate $autoTranslator)
    {
        parent::__construct();
        $this->autoTranslator = $autoTranslator;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $targetLanguages = Arr::wrap(config('auto-translate.target_language'));

        $this->line('Found '.count($targetLanguages).' languages to translate');

        $bar = $this->output->createProgressBar(count($targetLanguages));
        $bar->start();

        foreach ($targetLanguages as $targetLanguage) {
            $sourceTranslations = $this->autoTranslator->getSourceTranslations();

            $translated = $this->autoTranslator->translate($targetLanguage, $sourceTranslations);

            $this->autoTranslator->fillLanguageFiles($targetLanguage, $translated);

            $bar->advance();
        }

        $bar->finish();

        $this->info('Translated '.count(Arr::dot($sourceTranslations)).' language keys.');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2
3			namespace Ben182\AutoTranslate\Commands;
4
5			use Illuminate\Support\Arr;
6			use Illuminate\Console\Command;
7			use Ben182\AutoTranslate\AutoTranslate;
8
9			class AllCommand extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'autotrans:all';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Translates all source translations to target translations';
24
25			protected $autoTranslator;
26
27			/**
28			* Create a new command instance.
29			*
30			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-02-13 12:56 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
31			*/
32			public function __construct(AutoTranslate $autoTranslator)
33			{
34			parent::__construct();
35			$this->autoTranslator = $autoTranslator;
36			}
37
38			/**
39			* Execute the console command.
40			*
41			* @return mixed
42			*/
43			public function handle()
44			{
45			$targetLanguages = Arr::wrap(config('auto-translate.target_language'));
46
47			$this->line('Found '.count($targetLanguages).' languages to translate');
48
49			$bar = $this->output->createProgressBar(count($targetLanguages));
50			$bar->start();
51
52			foreach ($targetLanguages as $targetLanguage) {
53			$sourceTranslations = $this->autoTranslator->getSourceTranslations();
54
55			$translated = $this->autoTranslator->translate($targetLanguage, $sourceTranslations);
56
57			$this->autoTranslator->fillLanguageFiles($targetLanguage, $translated);
58
59			$bar->advance();
60			}
61
62			$bar->finish();
63
64			$this->info('Translated '.count(Arr::dot($sourceTranslations)).' language keys.');
			0 ignored issues – show Bug introduced 2019-02-13 12:56 UTC by Report Bug Copy Issue Report The variable `$sourceTranslations` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
65			}
66			}
67

ben182 / laravel-auto-translate

Push — master ( 4e6963...479a33 )

AllCommand::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like