MissingCommand::handle() - Code Metrics - Inspection of "Add support for translating JSON files" - ben182/laravel-auto-translate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

unknown

created 2019-08-22 19:36 UTC

MissingCommand::handle() A

↳ Parent: MissingCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	14
loc	14
ccs	0
cts	11
cp	0
rs	9.7998
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace Ben182\AutoTranslate\Commands;

use Illuminate\Support\Arr;
use Illuminate\Support\Str;
use Illuminate\Console\Command;
use Ben182\AutoTranslate\AutoTranslators\JsonTranslator;
use Ben182\AutoTranslate\AutoTranslators\PhpTranslator;

class MissingCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'autotrans:missing';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Translates all source translations that are not set in your target translations';

    protected $phpTranslator;
    protected $jsonTranslator;

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct(PhpTranslator $phpTranslator, JsonTranslator $jsonTranslator)

    {
        parent::__construct();
        $this->phpTranslator = $phpTranslator;
        $this->jsonTranslator = $jsonTranslator;
        $this->targetLanguages = Arr::wrap(config('auto-translate.target_language'));
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()

    {
        $numTargetLanguages = count($this->targetLanguages);

        $this->line(implode(' ', [
            'Found',
            $numTargetLanguages,
            Str::plural('language', $numTargetLanguages),
            'to translate',
        ]));

        $this->translatePhpFiles();
        $this->translateJsonFiles();
    }

    public function translatePhpFiles()

    {
        $this->line('Translating PHP files');

        $missingCount = 0;
        foreach ($this->targetLanguages as $targetLanguage) {
            $missingTranslations = $this->phpTranslator->getMissingTranslations($targetLanguage);
            $missingCount += count($missingTranslations);

            $this->line(implode(' ', [
                'Found',
                count($missingTranslations),
                'missing keys in',
                $targetLanguage,
            ]));
        }

        $bar = $this->output->createProgressBar($missingCount);
        $bar->start();

        $this->phpTranslator->translateMissing($this->targetLanguages, function () use ($bar) {
            $bar->advance();
        });

        $bar->finish();

        $this->info("\nTranslated ".$missingCount.' missing language keys.');
    }

    public function translateJsonFiles()

    {
        $this->line('Translating JSON files');

        $missingCount = 0;
        foreach ($this->targetLanguages as $targetLanguage) {
            $missingTranslations = $this->jsonTranslator->getMissingTranslations($targetLanguage);
            $missingCount += count($missingTranslations);

            $this->line(implode(' ', [
                'Found',
                count($missingTranslations),
                'missing keys in',
                $targetLanguage,
            ]));
        }

        $bar = $this->output->createProgressBar($missingCount);
        $bar->start();

        $this->jsonTranslator->translateMissing($this->targetLanguages, function () use ($bar) {
            $bar->advance();
        });

        $bar->finish();

        $this->info("\nTranslated ".$missingCount.' missing language keys.');
    }
}


1		<?php
2
3		namespace Ben182\AutoTranslate\Commands;
4
5		use Illuminate\Support\Arr;
6		use Illuminate\Support\Str;
7		use Illuminate\Console\Command;
8		use Ben182\AutoTranslate\AutoTranslators\JsonTranslator;
9		use Ben182\AutoTranslate\AutoTranslators\PhpTranslator;
10
11		class MissingCommand extends Command
12		{
13		/**
14		* The name and signature of the console command.
15		*
16		* @var string
17		*/
18		protected $signature = 'autotrans:missing';
19
20		/**
21		* The console command description.
22		*
23		* @var string
24		*/
25		protected $description = 'Translates all source translations that are not set in your target translations';
26
27		protected $phpTranslator;
28		protected $jsonTranslator;
29
30		/**
31		* Create a new command instance.
32		*
33		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
34		*/
35	View Code Duplication	public function __construct(PhpTranslator $phpTranslator, JsonTranslator $jsonTranslator)
		0 ignored issues – show Duplication introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		parent::__construct();
38		$this->phpTranslator = $phpTranslator;
39		$this->jsonTranslator = $jsonTranslator;
40		$this->targetLanguages = Arr::wrap(config('auto-translate.target_language'));
		0 ignored issues – show Bug introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report The property `targetLanguages` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41		}
42
43		/**
44		* Execute the console command.
45		*
46		* @return mixed
47		*/
48	View Code Duplication	public function handle()
		0 ignored issues – show Duplication introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$numTargetLanguages = count($this->targetLanguages);
51
52		$this->line(implode(' ', [
53		'Found',
54		$numTargetLanguages,
55		Str::plural('language', $numTargetLanguages),
56		'to translate',
57		]));
58
59		$this->translatePhpFiles();
60		$this->translateJsonFiles();
61		}
62
63	View Code Duplication	public function translatePhpFiles()
		0 ignored issues – show Duplication introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$this->line('Translating PHP files');
66
67		$missingCount = 0;
68		foreach ($this->targetLanguages as $targetLanguage) {
69		$missingTranslations = $this->phpTranslator->getMissingTranslations($targetLanguage);
70		$missingCount += count($missingTranslations);
71
72		$this->line(implode(' ', [
73		'Found',
74		count($missingTranslations),
75		'missing keys in',
76		$targetLanguage,
77		]));
78		}
79
80		$bar = $this->output->createProgressBar($missingCount);
81		$bar->start();
82
83		$this->phpTranslator->translateMissing($this->targetLanguages, function () use ($bar) {
84		$bar->advance();
85		});
86
87		$bar->finish();
88
89		$this->info("\nTranslated ".$missingCount.' missing language keys.');
90		}
91
92	View Code Duplication	public function translateJsonFiles()
		0 ignored issues – show Duplication introduced 2019-08-22 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		{
94		$this->line('Translating JSON files');
95
96		$missingCount = 0;
97		foreach ($this->targetLanguages as $targetLanguage) {
98		$missingTranslations = $this->jsonTranslator->getMissingTranslations($targetLanguage);
99		$missingCount += count($missingTranslations);
100
101		$this->line(implode(' ', [
102		'Found',
103		count($missingTranslations),
104		'missing keys in',
105		$targetLanguage,
106		]));
107		}
108
109		$bar = $this->output->createProgressBar($missingCount);
110		$bar->start();
111
112		$this->jsonTranslator->translateMissing($this->targetLanguages, function () use ($bar) {
113		$bar->advance();
114		});
115
116		$bar->finish();
117
118		$this->info("\nTranslated ".$missingCount.' missing language keys.');
119		}
120		}
121

ben182 / laravel-auto-translate

Pull Request — master (#29)

MissingCommand::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like