PdoMysqlAdapter::__construct() - Code Metrics - Inspection of "Updated API" - belgattitude/soluble-dbwrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dbcbc1...04d817 )

by Sébastien

created 2016-01-02 19:57 UTC

PdoMysqlAdapter::__construct() A

↳ Parent: PdoMysqlAdapter

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	5
Bugs	0	Features	1

Metric	Value
c	5
b	0
f	1
dl	0
loc	10
ccs	8
cts	8
cp	1
rs	9.4286
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php

namespace Soluble\DbWrapper\Adapter;

use Soluble\DbWrapper\Exception;
use Soluble\DbWrapper\Adapter\Pdo\GenericPdo;
use Soluble\DbWrapper\Connection\MysqlConnection;
use PDO;

class PdoMysqlAdapter extends GenericPdo implements AdapterInterface
{

    /**
     *
     * @var \PDO
     */
    protected $resource;


    /**
     * Constructor
     *
     * @throws Exception\InvalidArgumentException
     * @throws Exception\RuntimeException
     * @param \PDO $resource
     * @param \PDO $connection
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(PDO $resource)
    {
        $this->checkEnvironment();
        if ($resource->getAttribute(\PDO::ATTR_DRIVER_NAME) != 'mysql') {
            $msg = __CLASS__ . " requires pdo connection to be 'mysql'";
            throw new Exception\InvalidArgumentException($msg);
        }
        $this->resource = $resource;
        $this->connection = new MysqlConnection($this, $resource);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
    
    /**
     * {@inheritdoc}
     * @return MysqlConnection
     */
    public function getConnection() 
    {
        return $this->connection;
    }
    
}


1		<?php
2
3		namespace Soluble\DbWrapper\Adapter;
4
5		use Soluble\DbWrapper\Exception;
6		use Soluble\DbWrapper\Adapter\Pdo\GenericPdo;
7		use Soluble\DbWrapper\Connection\MysqlConnection;
8		use PDO;
9
10		class PdoMysqlAdapter extends GenericPdo implements AdapterInterface
11		{
12
13		/**
14		*
15		* @var \PDO
16		*/
17		protected $resource;
18
19
20		/**
21		* Constructor
22		*
23		* @throws Exception\InvalidArgumentException
24		* @throws Exception\RuntimeException
25		* @param \PDO $resource
26		* @param \PDO $connection
		0 ignored issues – show Bug introduced 2016-01-02 19:59 UTC by Report Bug Copy Issue Report There is no parameter named `$connection`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
27		*/
28	7	public function __construct(PDO $resource)
29		{
30	7	$this->checkEnvironment();
31	7	if ($resource->getAttribute(\PDO::ATTR_DRIVER_NAME) != 'mysql') {
32	1	$msg = __CLASS__ . " requires pdo connection to be 'mysql'";
33	1	throw new Exception\InvalidArgumentException($msg);
34		}
35	7	$this->resource = $resource;
36	7	$this->connection = new MysqlConnection($this, $resource);
		0 ignored issues – show Bug introduced 2016-01-02 19:59 UTC by Report Bug Copy Issue Report The property `connection` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37	7	}
38
39		/**
40		* {@inheritdoc}
41		* @return MysqlConnection
42		*/
43	2	public function getConnection()
44		{
45	2	return $this->connection;
46		}
47
48		}
49

belgattitude / soluble-dbwrapper

Push — master ( dbcbc1...04d817 )

PdoMysqlAdapter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like