PjbServer\Tools\Console\Command\PjbServerRevealCommand::execute()

Complexity

Conditions	3
Paths	2

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.072

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $logger = $this->getConsoleLogger($output);

        $file = $input->getArgument('config-file');

        // Test if config file exists
        if (!file_exists($file) || !is_readable($file)) {

It seems like $file can also be of type null and string[]; however, parameter $filename of file_exists() does only seem to accept string, maybe add an additional type check?

It seems like $file can also be of type null and string[]; however, parameter $filename of is_readable() does only seem to accept string, maybe add an additional type check?

            $msg = "Configuration file '$file' does not exists or is not readable'";
            throw new \InvalidArgumentException($msg);
        }

        $params = include $file;

        $config = new StandaloneServer\Config($params);
        $this->logServerConfig($logger, $config);
        $this->server = new StandaloneServer($config, $logger);

        $output->writeln($this->server->getCommand());

        return 1;
    }