WithBodyStreamTrait::getBodyLength() - Code Metrics - Inspection of "Merge pull request #18 from bee4/feature/configura..." - bee4/transport - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f62226...8b6b73 )

by Stéphane

created 2016-08-29 07:47 UTC

WithBodyStreamTrait::getBodyLength() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	9.4285
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php
/**
 * This file is part of the bee4/transport package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright Bee4 2015
 * @author Stephane HULARD <[email protected]>
 * @package Bee4\Transport\Message
 */
namespace Bee4\Transport\Message;

use Bee4\Transport\Exception\InvalidArgumentException;

/**
 * Allow the body to be a stream
 * @package Bee4\Transport\Message
 */
trait WithBodyStreamTrait
{
    use WithBodyTrait {
        WithBodyTrait::setBody as private setStringBody;
    }

    /**
     * Set body with stream acceptance
     * @param resource|string $body Request body
     * @throws InvalidArgumentException
     */
    public function setBody($body)
    {
        if (is_string($body)) {
            return $this->setStringBody($body);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        if (!is_resource($body)) {
            throw new InvalidArgumentException('Body must be a stream !');
        }
        if (!stream_is_local($body)) {
            throw new InvalidArgumentException('Body must be a local stream !');
        }

        rewind($body);
        $this->body = $body;

    }

    /**
     * Check if the current body is a stream or not
     * @return boolean
     */
    public function hasBodyStream()
    {
        return is_resource($this->getBody());
    }
}


1		<?php
2		/**
3		* This file is part of the bee4/transport package.
4		* For the full copyright and license information, please view the LICENSE
5		* file that was distributed with this source code.
6		*
7		* @copyright Bee4 2015
8		* @author Stephane HULARD <[email protected]>
9		* @package Bee4\Transport\Message
10		*/
11		namespace Bee4\Transport\Message;
12
13		use Bee4\Transport\Exception\InvalidArgumentException;
14
15		/**
16		* Allow the body to be a stream
17		* @package Bee4\Transport\Message
18		*/
19		trait WithBodyStreamTrait
20		{
21		use WithBodyTrait {
22		WithBodyTrait::setBody as private setStringBody;
23		}
24
25		/**
26		* Set body with stream acceptance
27		* @param resource\|string $body Request body
28		* @throws InvalidArgumentException
29		*/
30	2	public function setBody($body)
31		{
32	2	if (is_string($body)) {
33	1	return $this->setStringBody($body);
		0 ignored issues – show Bug introduced 2015-11-24 15:02 UTC by Report Bug Copy Issue Report It seems like `setStringBody()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34		}
35
36	2	if (!is_resource($body)) {
37		throw new InvalidArgumentException('Body must be a stream !');
38		}
39	2	if (!stream_is_local($body)) {
40		throw new InvalidArgumentException('Body must be a local stream !');
41		}
42
43	2	rewind($body);
44	2	$this->body = $body;
		0 ignored issues – show Documentation Bug introduced 2015-11-24 15:02 UTC by Report Bug Copy Issue Report It seems like `$body` of type `resource` is incompatible with the declared type `string` of property `$body`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
45	2	}
46
47		/**
48		* Check if the current body is a stream or not
49		* @return boolean
50		*/
51	3	public function hasBodyStream()
52		{
53	3	return is_resource($this->getBody());
54		}
55		}
56

bee4 / transport

Push — master ( f62226...8b6b73 )

WithBodyStreamTrait::getBodyLength() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like