Bee4\Transport\Message\Request\RequestFactory

Complexity

Total Complexity

7

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

94.74%

Importance

Changes	5
Bugs	2	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	build()	0	18	3
A	isAllowedScheme()	0	12	4

<?php
/**
 * This file is part of the bee4/transport package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright Bee4 2015
 * @author  Stephane HULARD <s.hulard@chstudio.fr>
 * @package Bee4\Transport\Message\Request
 */

namespace Bee4\Transport\Message\Request;

use Bee4\Transport\Exception\UnknownProtocolException;
use Bee4\Transport\Url;

/**
 * Static object in charge to build and initialize Request instance
 * @package Bee4\Transport\Message\Request
 */
class RequestFactory
{
    /**
     * Build a new request from parameters
     * @param string $method
     * @param Url $url
     * @param array $headers
     * @return AbstractRequest
     * @throws UnknownProtocolException
     * @throws InvalidArgumentException
     */
    public function build($method, Url $url, array $headers)
    {
        if (($scheme = self::isAllowedScheme($url->scheme())) === false) {

It seems like $url->scheme() targeting Bee4\Transport\Url::scheme() can also be of type object<Bee4\Transport\Url>; however, Bee4\Transport\Message\Request\RequestFactory::isAllowedScheme() does only seem to accept string, maybe add an additional type check?

            throw new UnknownProtocolException(sprintf(
                "You can't request a transfer on unsupported protocol '%s'!",
                $url->scheme()
            ));
        }

        $name = __NAMESPACE__.'\\'.ucfirst($scheme).'\\'.ucfirst(strtolower($method));
        if (!class_exists($name)) {
            throw new \InvalidArgumentException('Method given is not a valid request: '.$method);
        }

        $request = new $name($url, $headers);

        return $request;
    }

    /**
     * Validate scheme by checking if its an allowed one
     * @param string $scheme
     * @return boolean|string If invalid, false, else return the request known one
     */
    private static function isAllowedScheme($scheme)
    {
        if (preg_match(AbstractRequest::HTTP, $scheme) === 1) {
            return 'http';
        } elseif (preg_match(AbstractRequest::FTP, $scheme) === 1) {
            return 'ftp';
        } elseif (preg_match(AbstractRequest::SSH, $scheme) === 1) {
            return 'ssh';
        } else {
            return false;
        }
    }
}