BEdita\I18n\Filesystem\Ttag::extract()

Complexity

Conditions	10
Paths	35

Size

Total Lines	45
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public static function extract(array $locales, string $localePath, ?string $plugin = null): array
    {
        $extracted = false;
        $info = [];

        // check ttag command exists
        $ttag = 'node_modules/ttag-cli/bin/ttag';
        if (!file_exists($ttag)) {
            $info[] = sprintf('Skip javascript parsing - %s command not found', $ttag);

            return compact('extracted', 'info');
        }
        // check template folder exists
        $appDir = !empty($plugin) ? Plugin::templatePath($plugin) : Hash::get(App::path(View::NAME_TEMPLATE), 0);
        if (!file_exists($appDir)) {

It seems like $appDir can also be of type null; however, parameter $filename of file_exists() does only seem to accept string, maybe add an additional type check?

            $info[] = sprintf('Skip javascript parsing - %s folder not found', $appDir);

            return compact('extracted', 'info');
        }
        // Path to the resources directory defined in cakephp app config/paths.php
        // Do not add RESOURCES path when it's a plugin
        if (empty($plugin) && defined('RESOURCES') && file_exists(RESOURCES)) {

The constant BEdita\I18n\Filesystem\RESOURCES was not found. Maybe you did not declare it correctly or list all dependencies?

            $appDir = sprintf('%s %s', $appDir, RESOURCES);
        }

        // do extract translation strings from js files using ttag
        $info[] = 'Extracting translation string from javascript files using ttag';

        $defaultJs = sprintf('%s/default-js.pot', $localePath);
        foreach ($locales as $locale) {
            $lang = substr($locale, 0, 2);
            exec(sprintf('%s extract --extractLocation never --o %s --l %s %s', $ttag, $defaultJs, $lang, $appDir));
        }

        // merge default-js.pot and <plugin>.pot|default.pot
        $potFile = !empty($plugin) && is_string($plugin) ? sprintf('%s.pot', $plugin) : 'default.pot';
        $default = sprintf('%s/%s', $localePath, $potFile);
        exec(sprintf('msgcat --use-first %s %s -o %s', $default, $defaultJs, $default));

        // remove default-js.pot
        unlink($defaultJs);

        $extracted = true;

        return compact('extracted', 'info');
    }