Complex classes like Audit often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Audit, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 48 | class Audit extends Module |
||
| 49 | { |
||
| 50 | /** |
||
| 51 | * @var string|boolean the layout that should be applied for views within this module. This refers to a view name |
||
| 52 | * relative to [[layoutPath]]. If this is not set, it means the layout value of the [[module|parent module]] |
||
| 53 | * will be taken. If this is false, layout will be disabled within this module. |
||
| 54 | */ |
||
| 55 | public $layout = 'main'; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var string name of the component to use for database access |
||
| 59 | */ |
||
| 60 | public $db = 'db'; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var string[] Action or list of actions to track. '*' is allowed as the first or last character to use as wildcard. |
||
| 64 | */ |
||
| 65 | public $trackActions = ['*']; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var string[] Action or list of actions to ignore. '*' is allowed as the first or last character to use as wildcard (eg 'debug/*'). |
||
| 69 | */ |
||
| 70 | public $ignoreActions = []; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var int Maximum age (in days) of the audit entries before they are truncated |
||
| 74 | */ |
||
| 75 | public $maxAge = null; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @var string[] IP address or list of IP addresses with access to the viewer, null for everyone (if the IP matches) |
||
| 79 | * An IP address can contain the wildcard `*` at the end so that it matches IP addresses with the same prefix. |
||
| 80 | * For example, '192.168.*' matches all IP addresses in the segment '192.168.'. |
||
| 81 | */ |
||
| 82 | public $accessIps = null; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @var string[] Role or list of roles with access to the viewer, null for everyone (if the user matches) |
||
| 86 | */ |
||
| 87 | public $accessRoles = ['admin']; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @var int[] User ID or list of user IDs with access to the viewer, null for everyone (if the role matches) |
||
| 91 | */ |
||
| 92 | public $accessUsers = null; |
||
| 93 | |||
| 94 | /** |
||
| 95 | * @var bool Compress extra data generated or just keep in text? For people who don't like binary data in the DB |
||
| 96 | */ |
||
| 97 | public $compressData = true; |
||
| 98 | |||
| 99 | /** |
||
| 100 | * @var string The callback to use to convert a user id into an identifier (username, email, ...). Can also be html. |
||
| 101 | */ |
||
| 102 | public $userIdentifierCallback = false; |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @var string The callback to get a user id. |
||
| 106 | */ |
||
| 107 | public $userIdCallback = false; |
||
| 108 | |||
| 109 | /** |
||
| 110 | * @var string Will be called to translate text in the user filter into a (or more) user id's |
||
| 111 | */ |
||
| 112 | public $userFilterCallback = false; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @var bool The module does batch saving of the data records by default. You can disable this if you are experiencing |
||
| 116 | * `max_allowed_packet` errors when logging huge data quantities. Records will be saved per piece instead of all at once |
||
| 117 | */ |
||
| 118 | public $batchSave = true; |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @var array Default log levels to filter and process |
||
| 122 | */ |
||
| 123 | public $logConfig = ['levels' => ['error', 'warning', 'info', 'profile']]; |
||
| 124 | |||
| 125 | |||
| 126 | /** |
||
| 127 | * @var array|Panel[] list of panels that should be active/tracking/available during the auditing phase. |
||
| 128 | * If the value is a simple string, it is the identifier of an internal panel to activate (with default settings) |
||
| 129 | * If the entry is a '<key>' => '<string>|<array>' it is either a new panel or a panel override (if you specify a core id). |
||
| 130 | * It is important that the key is unique, as this is the identifier used to store any data associated with the panel. |
||
| 131 | * |
||
| 132 | * Please note: |
||
| 133 | * - If you just want to change the configuration for a core panel, use the `$panelConfiguration`, it will be merged into this one |
||
| 134 | * - If you add custom panels, please namespace them ("mynamespace/panelname"). |
||
| 135 | */ |
||
| 136 | public $panels = [ |
||
| 137 | 'audit/request', |
||
| 138 | 'audit/db', |
||
| 139 | 'audit/log', |
||
| 140 | 'audit/mail', |
||
| 141 | 'audit/profiling', |
||
| 142 | 'audit/trail', |
||
| 143 | 'audit/javascript', |
||
| 144 | // 'audit/asset', |
||
| 145 | // 'audit/config', |
||
| 146 | |||
| 147 | // These provide special functionality and get loaded to activate it |
||
| 148 | 'audit/error', // Links the extra error reporting functions (`exception()` and `errorMessage()`) |
||
| 149 | 'audit/extra', // Links the data functions (`data()`) |
||
| 150 | 'audit/curl', // Links the curl tracking function (`curlBegin()`, `curlEnd()` and `curlExec()`) |
||
| 151 | ]; |
||
| 152 | |||
| 153 | /** |
||
| 154 | * Everything you add in here will be merged with the basic panel configuration. |
||
| 155 | * This gives you an easy way to just add or modify panels/configurations without having to re-specify every panel. |
||
| 156 | * This only accepts regular definitions ('<key>' => '<array>'), but the core class will be added if needed |
||
| 157 | * Take a look at the [module configuration](docs/module-configuration.md) for more information. |
||
| 158 | */ |
||
| 159 | public $panelsMerge = []; |
||
| 160 | |||
| 161 | /** |
||
| 162 | * @var LogTarget |
||
| 163 | */ |
||
| 164 | public $logTarget; |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @see \yii\debug\Module::$traceLine |
||
| 168 | */ |
||
| 169 | public $traceLine = \yii\debug\Module::DEFAULT_IDE_TRACELINE; |
||
| 170 | |||
| 171 | /** |
||
| 172 | * @var array |
||
| 173 | */ |
||
| 174 | private $_corePanels = [ |
||
| 175 | // Tracking/logging panels |
||
| 176 | 'audit/request' => ['class' => 'bedezign\yii2\audit\panels\RequestPanel'], |
||
| 177 | 'audit/db' => ['class' => 'bedezign\yii2\audit\panels\DbPanel'], |
||
| 178 | 'audit/log' => ['class' => 'bedezign\yii2\audit\panels\LogPanel'], |
||
| 179 | 'audit/asset' => ['class' => 'bedezign\yii2\audit\panels\AssetPanel'], |
||
| 180 | 'audit/config' => ['class' => 'bedezign\yii2\audit\panels\ConfigPanel'], |
||
| 181 | 'audit/profiling' => ['class' => 'bedezign\yii2\audit\panels\ProfilingPanel'], |
||
| 182 | |||
| 183 | // Special other panels |
||
| 184 | 'audit/error' => ['class' => 'bedezign\yii2\audit\panels\ErrorPanel'], |
||
| 185 | 'audit/javascript' => ['class' => 'bedezign\yii2\audit\panels\JavascriptPanel'], |
||
| 186 | 'audit/trail' => ['class' => 'bedezign\yii2\audit\panels\TrailPanel'], |
||
| 187 | 'audit/mail' => ['class' => 'bedezign\yii2\audit\panels\MailPanel'], |
||
| 188 | 'audit/extra' => ['class' => 'bedezign\yii2\audit\panels\ExtraDataPanel'], |
||
| 189 | 'audit/curl' => ['class' => 'bedezign\yii2\audit\panels\CurlPanel'], |
||
| 190 | 'audit/soap' => ['class' => 'bedezign\yii2\audit\panels\SoapPanel'], |
||
| 191 | ]; |
||
| 192 | |||
| 193 | /** |
||
| 194 | * @var array |
||
| 195 | */ |
||
| 196 | private $_panelFunctions = []; |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @var \bedezign\yii2\audit\models\AuditEntry If activated this is the active entry |
||
| 200 | */ |
||
| 201 | private $_entry = null; |
||
| 202 | |||
| 203 | /** |
||
| 204 | * @throws InvalidConfigException |
||
| 205 | */ |
||
| 206 | 78 | public function init() |
|
| 229 | |||
| 230 | /** |
||
| 231 | 78 | * Called to evaluate if the current request should be logged |
|
| 232 | 78 | * @param ActionEvent $event |
|
| 233 | 78 | */ |
|
| 234 | public function onBeforeAction($event) |
||
| 245 | 54 | ||
| 246 | /** |
||
| 247 | * |
||
| 248 | 39 | */ |
|
| 249 | 39 | public function onAfterRequest() |
|
| 255 | |||
| 256 | 57 | /** |
|
| 257 | 57 | * Allows panels to register functions that can be called directly on the module |
|
| 258 | 57 | * @param string $name |
|
| 259 | 57 | * @param callable $callback |
|
| 260 | */ |
||
| 261 | public function registerFunction($name, $callback) |
||
| 268 | 78 | ||
| 269 | 78 | /** |
|
| 270 | * @param \yii\debug\Panel $panel |
||
| 271 | 78 | */ |
|
| 272 | 78 | public function registerPanel(\yii\debug\Panel $panel) |
|
| 276 | |||
| 277 | /** |
||
| 278 | * @param string $name |
||
| 279 | * @param array $params |
||
| 280 | * @return mixed |
||
| 281 | */ |
||
| 282 | public function __call($name, $params) |
||
| 289 | 21 | ||
| 290 | 21 | public function activateLogTarget() |
|
| 301 | |||
| 302 | /** |
||
| 303 | * @return \yii\db\Connection the database connection. |
||
| 304 | */ |
||
| 305 | public function getDb() |
||
| 309 | |||
| 310 | 171 | /** |
|
| 311 | 171 | * @param bool $create |
|
| 312 | 171 | * @param bool $new |
|
| 313 | 171 | * @return AuditEntry |
|
| 314 | 117 | */ |
|
| 315 | 117 | public function getEntry($create = false, $new = false) |
|
| 326 | 18 | ||
| 327 | /** |
||
| 328 | * @param $user_id |
||
| 329 | 18 | * @return string |
|
| 330 | 3 | */ |
|
| 331 | public function getUserIdentifier($user_id) |
||
| 341 | 3 | ||
| 342 | /** |
||
| 343 | 117 | * @return int|mixed|null|string |
|
| 344 | */ |
||
| 345 | public function getUserId() |
||
| 352 | 3 | ||
| 353 | /** |
||
| 354 | * Returns a list of all available panel identifiers |
||
| 355 | * @return string[] |
||
| 356 | */ |
||
| 357 | public function getPanelIdentifiers() |
||
| 361 | |||
| 362 | 78 | /** |
|
| 363 | 78 | * Tries to assemble the configuration for the panels that the user wants for auditing |
|
| 364 | 78 | * @param string[] Set of panel identifiers that should be loaded |
|
| 365 | 78 | * @return Panel[] |
|
| 366 | 78 | */ |
|
| 367 | public function loadPanels($list) |
||
| 375 | |||
| 376 | 114 | /** |
|
| 377 | 114 | * @param string $identifier |
|
| 378 | 114 | * @return null|Panel |
|
| 379 | 3 | * @throws InvalidConfigException |
|
| 380 | 3 | */ |
|
| 381 | public function getPanel($identifier) |
||
| 400 | 78 | ||
| 401 | 78 | /** |
|
| 402 | 78 | * Make sure the configured panels array is a uniform set of <identifier> => <config> entries. |
|
| 403 | * @throws InvalidConfigException |
||
| 404 | 78 | */ |
|
| 405 | 78 | protected function normalizePanelConfiguration() |
|
| 432 | 81 | ||
| 433 | 81 | /** |
|
| 434 | 81 | * @return int|null|string |
|
| 435 | 81 | */ |
|
| 436 | 78 | public static function findModuleIdentifier() |
|
| 455 | 27 | ||
| 456 | 27 | /** |
|
| 457 | 27 | * @param string $className |
|
| 458 | 27 | * @return bool|string |
|
| 459 | */ |
||
| 460 | 27 | public static function findPanelIdentifier($className) |
|
| 470 | |||
| 471 | /** |
||
| 472 | * Verifies a route against a given list and returns whether it matches or not. |
||
| 473 | 84 | * Entries in the list are allowed to end with a '*', which means that a substring will be used for the match |
|
| 474 | * instead of a full compare. |
||
| 475 | 84 | * |
|
| 476 | 84 | * @param string $route An application rout |
|
| 477 | 84 | * @param string[] $list List of routes to compare against. |
|
| 478 | 84 | * @return bool |
|
| 479 | 54 | */ |
|
| 480 | 54 | protected function routeMatches($route, $list) |
|
| 502 | |||
| 503 | } |
||
| 504 |