Issues in AssertionExceptionCallbackTest.php - New Issues - Inspection of "CS" - beberlei/assert - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66b06b...821c6e )

by Richard

created 2017-01-06 15:31 UTC

Assert/Tests/AssertionExceptionCallbackTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Assert
 *
 * LICENSE
 *
 * This source file is subject to the MIT license that is bundled
 * with this package in the file LICENSE.txt.
 * If you did not receive a copy of the license and are unable to
 * obtain it through the world-wide-web, please send an email
 * to [email protected] so I can send you a copy immediately.
 */

namespace Assert\Tests;

use Assert\Assertion;
use Assert\AssertionFailedException;

class AssertionExceptionCallbackTest extends \PHPUnit_Framework_TestCase
{
    public function testMessageCallback()
    {
        $this->setExpectedException(AssertionFailedException::class, 'The value of M_PI is not regarded as a string');
        Assertion::string(M_PI, function ($value, $propertyPath = null) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return 'The value of M_PI is not regarded as a string';
        });
    }
}


1			<?php
2
3			/**
4			* Assert
5			*
6			* LICENSE
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this package in the file LICENSE.txt.
10			* If you did not receive a copy of the license and are unable to
11			* obtain it through the world-wide-web, please send an email
12			* to [email protected] so I can send you a copy immediately.
13			*/
14
15			namespace Assert\Tests;
16
17			use Assert\Assertion;
18			use Assert\AssertionFailedException;
19
20			class AssertionExceptionCallbackTest extends \PHPUnit_Framework_TestCase
21			{
22			public function testMessageCallback()
23			{
24			$this->setExpectedException(AssertionFailedException::class, 'The value of M_PI is not regarded as a string');
25			Assertion::string(M_PI, function ($value, $propertyPath = null) {
			0 ignored issues – show Documentation introduced 2017-01-06 15:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `function ($value, $prope...egarded as a string'; }` is of type `object<Closure>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			return 'The value of M_PI is not regarded as a string';
27			});
28			}
29			}
30

beberlei / assert

Push — master ( 66b06b...821c6e )

Assert/Tests/AssertionExceptionCallbackTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like