bearsunday / BEAR.Resource

src/AssistedWebContextParam.php

<?php

declare(strict_types=1);

namespace BEAR\Resource;

use Override;
use Ray\Di\InjectorInterface;
use Ray\WebContextParam\Annotation\AbstractWebContextParam;

use function assert;
use function is_string;

/**
 * @psalm-import-type Query from Types
 * @psalm-import-type SuperGlobalsMap from Types
 */
final class AssistedWebContextParam implements ParamInterface
{
    /**
     * $GLOBALS for testing
     *
     * @var SuperGlobalsMap

The type BEAR\Resource\SuperGlobalsMap was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    private static array $globals = [];

    public function __construct(
        private readonly AbstractWebContextParam $webContextParam,
        private readonly ParamInterface $defaultParam,
    ) {
    }

    /**
     * {@inheritDoc}
     */
    #[Override]
    public function __invoke(string $varName, array $query, InjectorInterface $injector)
    {
        $superGlobals = static::$globals ?: $GLOBALS;

Since $globals is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $globals to at least protected.

        /** @var SuperGlobalsMap $superGlobals */
        $webContextParam = $this->webContextParam;
        assert(is_string($webContextParam::GLOBAL_KEY));
        /** @psalm-suppress MixedArrayOffset */
        $phpWebContext = $superGlobals[$webContextParam::GLOBAL_KEY];

        return $phpWebContext[$this->webContextParam->key] ?? ($this->defaultParam)($varName, $query, $injector);
    }

    /** @param SuperGlobalsMap $globals */
    public static function setSuperGlobalsOnlyForTestingPurpose(array $globals): void
    {
        self::$globals = $globals;

It seems like $globals of type array is incompatible with the declared type BEAR\Resource\SuperGlobalsMap of property $globals.

    }
}