StorageRedisModule::__construct() - Code Metrics - Inspection of "soothe phpstan" - bearsunday/BEAR.QueryRepository - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — spike ( 20d8a1...1c889c )

by Akihito

created 2018-05-23 13:37 UTC

StorageRedisModule::__construct() A

↳ Parent: StorageRedisModule

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	2

<?php
/**
 * This file is part of the BEAR.QueryRepository package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\QueryRepository;

use BEAR\RepositoryModule\Annotation\Storage;
use Doctrine\Common\Cache\CacheProvider;
use Ray\Di\AbstractModule;

class StorageRedisModule extends AbstractModule
{
    /**
     * @var array
     */
    private $server;

    /**
     * @param string              $server {host}:{port} format
     * @param AbstractModule|null $module
     */
    public function __construct(string $server, AbstractModule $module = null)
    {
        $this->server = \explode(':', $server);
        parent::__construct($module);

    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->bind()->annotatedWith('redis_server')->toInstance($this->server);
        $this->bind(CacheProvider::class)->annotatedWith(Storage::class)->toProvider(StorageRedisCacheProvider::class);
    }
}


1			<?php
2			/**
3			* This file is part of the BEAR.QueryRepository package.
4			*
5			* @license http://opensource.org/licenses/MIT MIT
6			*/
7			namespace BEAR\QueryRepository;
8
9			use BEAR\RepositoryModule\Annotation\Storage;
10			use Doctrine\Common\Cache\CacheProvider;
11			use Ray\Di\AbstractModule;
12
13			class StorageRedisModule extends AbstractModule
14			{
15			/**
16			* @var array
17			*/
18			private $server;
19
20			/**
21			* @param string $server {host}:{port} format
22			* @param AbstractModule\|null $module
23			*/
24			public function __construct(string $server, AbstractModule $module = null)
25			{
26			$this->server = \explode(':', $server);
27			parent::__construct($module);
			0 ignored issues – show Bug introduced 2018-03-19 03:09 UTC by Report Bug Copy Issue Report It seems like `$module` defined by parameter `$module` on line 24 can also be of type `object<Ray\Di\AbstractModule>`; however, `Ray\Di\AbstractModule::__construct()` does only seem to accept `null\|object<self>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
28			}
29
30			/**
31			* {@inheritdoc}
32			*/
33			protected function configure()
34			{
35			$this->bind()->annotatedWith('redis_server')->toInstance($this->server);
36			$this->bind(CacheProvider::class)->annotatedWith(Storage::class)->toProvider(StorageRedisCacheProvider::class);
37			}
38			}
39

bearsunday / BEAR.QueryRepository

Push — spike ( 20d8a1...1c889c )

StorageRedisModule::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like