BEAR\QueryRepository\RefreshSameCommand

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

96.15%

Importance

Changes	4
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	command()	0	19	3
A	getQuery()	0	14	3

<?php
/**
 * This file is part of the BEAR.QueryRepository package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\QueryRepository;

use BEAR\QueryRepository\Exception\UnmatchedQuery;
use BEAR\Resource\ResourceObject;
use Ray\Aop\MethodInvocation;

class RefreshSameCommand implements CommandInterface
{
    /**
     * @var QueryRepositoryInterface
     */
    private $repository;

    public function __construct(QueryRepositoryInterface $repository)
    {
        $this->repository = $repository;
    }

    /**
     * @param MethodInvocation $invocation
     * @param ResourceObject   $resourceObject
     */
    public function command(MethodInvocation $invocation, ResourceObject $resourceObject)
    {
        $method = $invocation->getMethod()->getName();

Consider using $invocation->getMethod()->name. There is an issue with getName() and APC-enabled PHP versions.

        if ($method === 'onGet' || $method === 'onPost') {
            return;
        }
        unset($invocation);
        $onGet = [$resourceObject, 'onGet'];
        $getQuery = $this->getQuery($resourceObject, $onGet);

The call to RefreshSameCommand::getQuery() has too many arguments starting with $onGet.

        $delUri = clone $resourceObject->uri;
        $delUri->query = $getQuery;

        // delete data in repository
        $this->repository->purge($delUri);

$delUri of type object<BEAR\Resource\AbstractUri> is not a sub-type of object<BEAR\Resource\Uri>. It seems like you assume a child class of the class BEAR\Resource\AbstractUri to be always present.

        // GET for re-generate (in interceptor)
        $resourceObject->uri->query = $getQuery;
        call_user_func_array($onGet, $getQuery);
    }

    /**
     * @param ResourceObject $resourceObject
     *
     * @return array
     */
    private function getQuery(ResourceObject $resourceObject)
    {
        $refParameters = (new \ReflectionMethod($resourceObject, 'onGet'))->getParameters();
        $getQuery = [];
        $query = $resourceObject->uri->query;
        foreach ($refParameters as $parameter) {
            if (! isset($query[$parameter->name])) {
                throw new UnmatchedQuery($resourceObject->uri->method . ' ' . (string) $resourceObject->uri);
            }
            $getQuery[$parameter->name] = $query[$parameter->name];
        }

        return $getQuery;
    }
}