BEAR\QueryRepository\CacheInterceptor

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

94.12%

Importance

Changes	6
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	invoke()	0	21	3

<?php
/**
 * This file is part of the BEAR.QueryRepository package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\QueryRepository;

use BEAR\RepositoryModule\Annotation\Cacheable;
use BEAR\Resource\ResourceObject;
use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\Reader;
use Ray\Aop\MethodInterceptor;
use Ray\Aop\MethodInvocation;

class CacheInterceptor implements MethodInterceptor
{
    /**
     * @var QueryRepositoryInterface
     */
    private $repository;

    /**
     * @var EtagSetterInterface
     */
    private $setEtag;

    /**
     * @var AnnotationReader
     */
    private $reader;

    /**
     * @param QueryRepositoryInterface $repository
     * @param EtagSetterInterface      $setEtag
     */
    public function __construct(
        QueryRepositoryInterface $repository,
        EtagSetterInterface $setEtag,
        Reader $annotationReader
    ) {
        $this->repository = $repository;
        $this->setEtag = $setEtag;
        $this->reader = $annotationReader;

$annotationReader is of type object<Doctrine\Common\Annotations\Reader>, but the property $reader was declared to be of type object<Doctrine\Common\Annotations\AnnotationReader>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * {@inheritdoc}
     */
    public function invoke(MethodInvocation $invocation)
    {
        $resourceObject = $invocation->getThis();
        /* @var $resourceObject ResourceObject */
        $stored = $this->repository->get($resourceObject->uri);

$resourceObject->uri of type object<BEAR\Resource\AbstractUri> is not a sub-type of object<BEAR\Resource\Uri>. It seems like you assume a child class of the class BEAR\Resource\AbstractUri to be always present.

        if ($stored) {
            list($resourceObject->code, $resourceObject->headers, $resourceObject->body, $resourceObject->view) = $stored;

            return $resourceObject;
        }
        /* @var $cacheable Cacheable */
        try {
            $resourceObject = $invocation->proceed();
            $this->setEtag->__invoke($resourceObject);
            $this->repository->put($resourceObject);
        } catch (\Exception $e) {
            $this->repository->purge($resourceObject->uri);
        }

        return $resourceObject;
    }
}