CliHttpCache::transfer() - Code Metrics - Inspection of "Cleanup test code" - bearsunday/BEAR.QueryRepository - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — psalm ( 804131...7e613f )

by Akihito

created 2021-01-19 08:31 UTC

CliHttpCache::transfer() A

↳ Parent: CliHttpCache

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace BEAR\QueryRepository;

use BEAR\Sunday\Extension\Transfer\HttpCacheInterface;

use function assert;
use function is_string;
use function parse_str;
use function sprintf;
use function str_replace;
use function strtoupper;

use const PHP_EOL;

final class CliHttpCache implements HttpCacheInterface
{
    /** @var ResourceStorageInterface */
    private $storage;

    public function __construct(ResourceStorageInterface $storage)
    {
        $this->storage = $storage;
    }

    /**
     * {@inheritdoc}
     */
    public function isNotModified(array $server): bool
    {
        $etag = $this->getEtag($server);
        if ($etag === null) {
            return false;
        }

        return $this->storage->hasEtag($etag);
    }

    /**
     * {@inheritdoc}
     *
     * @return void
     */
    public function transfer()
    {
        echo '304 Not Modified' . PHP_EOL . PHP_EOL;
    }

    /**
     * @return array<string, string>

     */
    private function getServer(string $query): array
    {
        parse_str($query, $headers);
        $server = [];
        foreach ($headers as $key => $header) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            assert(is_string($header));
            assert(is_string($key));
            $server[$this->getServerKey($key)] = $header;
        }

        return $server;
    }

    private function getServerKey(string $key): string
    {
        return sprintf('HTTP_%s', strtoupper(str_replace('-', '_', $key)));
    }

    /**
     * @param array<string, mixed> $server
     */
    private function getEtag(array $server): ?string
    {
        $hasRequestHeaderInCli = isset($server['argc']) && $server['argc'] === 4 && isset($server['argv'][3]);
        if ($hasRequestHeaderInCli) {
            $server = $this->getServer((string) $server['argv'][3]);
        }

        $hasValidEtag = isset($server['HTTP_IF_NONE_MATCH']) && is_string($server['HTTP_IF_NONE_MATCH']);

        return $hasValidEtag ? $server['HTTP_IF_NONE_MATCH'] : null;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BEAR\QueryRepository;
6
7			use BEAR\Sunday\Extension\Transfer\HttpCacheInterface;
8
9			use function assert;
10			use function is_string;
11			use function parse_str;
12			use function sprintf;
13			use function str_replace;
14			use function strtoupper;
15
16			use const PHP_EOL;
17
18			final class CliHttpCache implements HttpCacheInterface
19			{
20			/** @var ResourceStorageInterface */
21			private $storage;
22
23			public function __construct(ResourceStorageInterface $storage)
24			{
25			$this->storage = $storage;
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function isNotModified(array $server): bool
32			{
33			$etag = $this->getEtag($server);
34			if ($etag === null) {
35			return false;
36			}
37
38			return $this->storage->hasEtag($etag);
39			}
40
41			/**
42			* {@inheritdoc}
43			*
44			* @return void
45			*/
46			public function transfer()
47			{
48			echo '304 Not Modified' . PHP_EOL . PHP_EOL;
49			}
50
51			/**
52			* @return array<string, string>
			0 ignored issues – show Documentation introduced 2021-01-17 02:13 UTC by Report Bug Copy Issue Report The doc-type `array<string,` could not be parsed: Expected ">" at position 5, but found "end of type". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
53			*/
54			private function getServer(string $query): array
55			{
56			parse_str($query, $headers);
57			$server = [];
58			foreach ($headers as $key => $header) {
			0 ignored issues – show Bug introduced 2018-10-23 08:57 UTC by Report Bug Copy Issue Report The expression `$headers` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
59			assert(is_string($header));
60			assert(is_string($key));
61			$server[$this->getServerKey($key)] = $header;
62			}
63
64			return $server;
65			}
66
67			private function getServerKey(string $key): string
68			{
69			return sprintf('HTTP_%s', strtoupper(str_replace('-', '_', $key)));
70			}
71
72			/**
73			* @param array<string, mixed> $server
74			*/
75			private function getEtag(array $server): ?string
76			{
77			$hasRequestHeaderInCli = isset($server['argc']) && $server['argc'] === 4 && isset($server['argv'][3]);
78			if ($hasRequestHeaderInCli) {
79			$server = $this->getServer((string) $server['argv'][3]);
80			}
81
82			$hasValidEtag = isset($server['HTTP_IF_NONE_MATCH']) && is_string($server['HTTP_IF_NONE_MATCH']);
83
84			return $hasValidEtag ? $server['HTTP_IF_NONE_MATCH'] : null;
85			}
86			}
87

bearsunday / BEAR.QueryRepository

Push — psalm ( 804131...7e613f )

CliHttpCache::transfer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like