BEAR\QueryRepository\StorageExpiryModule

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	configure()	0	4	1

<?php
/**
 * This file is part of the BEAR.QueryRepository package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\QueryRepository;

use BEAR\RepositoryModule\Annotation\ExpiryConfig;
use Ray\Di\AbstractModule;

class StorageExpiryModule extends AbstractModule
{
    /**
     * @var int
     */
    private $short;

    /**
     * @var int
     */
    private $medium;

    /**
     * @var int
     */
    private $long;

    /**
     * @param int            $short
     * @param int            $medium
     * @param int            $long
     * @param AbstractModule $module
     */
    public function __construct($short, $medium, $long, AbstractModule $module = null)

The parameter $medium is not used and could be removed.

The method parameter $medium is never used

    {
        $this->short = $short;
        $this->medium = $module;

It seems like $module can also be of type object<Ray\Di\AbstractModule>. However, the property $medium is declared as type integer. Maybe add an additional type check?

        $this->long = $long;
        parent::__construct($module);
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->bind()->annotatedWith(ExpiryConfig::class)->toInstance(new Expiry($this->short, $this->medium, $this->long));
    }
}