HeaderSetter::__invoke() - Code Metrics - Inspection of "Bump phpstan to 1.0.2" - bearsunday/BEAR.QueryRepository - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.x (#99)

by Akihito

created 2021-11-04 01:00 UTC

HeaderSetter::__invoke() A

↳ Parent: HeaderSetter

Complexity

Conditions	3
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	3
c	1
b	0
f	0
nc	2
nop	3
dl	0
loc	6
rs	10

<?php

declare(strict_types=1);

namespace BEAR\QueryRepository;

use BEAR\RepositoryModule\Annotation\HttpCache;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use BEAR\Resource\ResourceObject;

use function is_int;
use function sprintf;
use function strpos;

final class HeaderSetter
{
    /** @var EtagSetterInterface */
    private $etagSetter;

    public function __construct(EtagSetterInterface $etagSetter)
    {
        $this->etagSetter = $etagSetter;
    }

    public function __invoke(ResourceObject $ro, ?int $concheControlMaxAge, ?HttpCache $httpCache): void
    {
        ($this->etagSetter)($ro, null, $httpCache);

        if (is_int($concheControlMaxAge) && $concheControlMaxAge > 0) {
            $this->setCacheControlMaxAge($ro, $concheControlMaxAge);
        }
    }

    private function setCacheControlMaxAge(ResourceObject $ro, int $age): void
    {
        $setMaxAge = sprintf('max-age=%d', $age);
        $hasNoCacheControleHeader = ! isset($ro->headers[Header::CACHE_CONTROL]);
        $headers = $ro->headers;
        if ($hasNoCacheControleHeader) {
            $ro->headers[Header::CACHE_CONTROL] = $setMaxAge;

            return;
        }

        $isMaxAgeAlreadyDefined = strpos($headers[Header::CACHE_CONTROL], 'max-age') !== false;
        if ($isMaxAgeAlreadyDefined) {
            return;
        }

        if (isset($ro->headers[Header::CACHE_CONTROL])) {
            $ro->headers[Header::CACHE_CONTROL] .= ', ' . $setMaxAge;
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BEAR\QueryRepository;
6
7			use BEAR\RepositoryModule\Annotation\HttpCache;
			0 ignored issues – show Bug introduced 2021-11-04 01:10 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `BEAR\QueryRepository\HttpCache`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8			use BEAR\Resource\ResourceObject;
9
10			use function is_int;
11			use function sprintf;
12			use function strpos;
13
14			final class HeaderSetter
15			{
16			/** @var EtagSetterInterface */
17			private $etagSetter;
18
19			public function __construct(EtagSetterInterface $etagSetter)
20			{
21			$this->etagSetter = $etagSetter;
22			}
23
24			public function __invoke(ResourceObject $ro, ?int $concheControlMaxAge, ?HttpCache $httpCache): void
25			{
26			($this->etagSetter)($ro, null, $httpCache);
27
28			if (is_int($concheControlMaxAge) && $concheControlMaxAge > 0) {
29			$this->setCacheControlMaxAge($ro, $concheControlMaxAge);
30			}
31			}
32
33			private function setCacheControlMaxAge(ResourceObject $ro, int $age): void
34			{
35			$setMaxAge = sprintf('max-age=%d', $age);
36			$hasNoCacheControleHeader = ! isset($ro->headers[Header::CACHE_CONTROL]);
37			$headers = $ro->headers;
38			if ($hasNoCacheControleHeader) {
39			$ro->headers[Header::CACHE_CONTROL] = $setMaxAge;
40
41			return;
42			}
43
44			$isMaxAgeAlreadyDefined = strpos($headers[Header::CACHE_CONTROL], 'max-age') !== false;
45			if ($isMaxAgeAlreadyDefined) {
46			return;
47			}
48
49			if (isset($ro->headers[Header::CACHE_CONTROL])) {
50			$ro->headers[Header::CACHE_CONTROL] .= ', ' . $setMaxAge;
51			}
52			}
53			}
54

bearsunday / BEAR.QueryRepository

Pull Request — 1.x (#99)

HeaderSetter::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like