Issues in ProdMonologProvider.php (remove-abandoned-doctrine-packages) - Issues in remove-abandoned-doctrine-packages - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Issues (74)

src/Provide/Logger/ProdMonologProvider.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace BEAR\Package\Provide\Logger;

use BEAR\AppMeta\AbstractAppMeta;
use Monolog\Handler\ErrorLogHandler;
use Monolog\Logger;
use Override;
use Ray\Di\ProviderInterface;

/** @implements ProviderInterface<Logger> */
final class ProdMonologProvider implements ProviderInterface
{
    public function __construct(
        private AbstractAppMeta $appMeta,
    ) {
    }

    #[Override]
    public function get(): Logger
    {
        return new Logger($this->appMeta->name, [new ErrorLogHandler()]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BEAR\Package\Provide\Logger;
6
7			use BEAR\AppMeta\AbstractAppMeta;
8			use Monolog\Handler\ErrorLogHandler;
9			use Monolog\Logger;
10			use Override;
11			use Ray\Di\ProviderInterface;
12
13			/** @implements ProviderInterface<Logger> */
14			final class ProdMonologProvider implements ProviderInterface
15			{
16			public function __construct(
17			private AbstractAppMeta $appMeta,
18			) {
19			}
20
21			#[Override]
22			public function get(): Logger
23			{
24			return new Logger($this->appMeta->name, [new ErrorLogHandler()]);
			0 ignored issues – show Bug Best Practice introduced 2022-03-20 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return new Monolog\Logge...ler\ErrorLogHandler()))` returns the type `Monolog\Logger` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
25			}
26			}
27

bearsunday / BEAR.Package

Issues (74)

src/Provide/Logger/ProdMonologProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like