Issues in MonologProvider.php (remove-abandoned-doctrine-packages) - Issues in remove-abandoned-doctrine-packages - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Issues (74)

src/Provide/Logger/MonologProvider.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace BEAR\Package\Provide\Logger;

use BEAR\AppMeta\AbstractAppMeta;
use Monolog\Formatter\LineFormatter;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use Override;
use Ray\Di\ProviderInterface;

/** @implements ProviderInterface<Logger> */
final class MonologProvider implements ProviderInterface
{
    public function __construct(
        private AbstractAppMeta $appMeta,
    ) {
    }

    /**
     * {@inheritDoc}
     */
    #[Override]
    public function get(): Logger
    {
        $format = "[%datetime%] %level_name%: %message% %context%\n";
        $stream = new StreamHandler($this->appMeta->logDir . '/app.log');
        $stream->setFormatter(new LineFormatter($format));

        return new Logger($this->appMeta->name, [$stream]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BEAR\Package\Provide\Logger;
6
7			use BEAR\AppMeta\AbstractAppMeta;
8			use Monolog\Formatter\LineFormatter;
9			use Monolog\Handler\StreamHandler;
10			use Monolog\Logger;
11			use Override;
12			use Ray\Di\ProviderInterface;
13
14			/** @implements ProviderInterface<Logger> */
15			final class MonologProvider implements ProviderInterface
16			{
17			public function __construct(
18			private AbstractAppMeta $appMeta,
19			) {
20			}
21
22			/**
23			* {@inheritDoc}
24			*/
25			#[Override]
26			public function get(): Logger
27			{
28			$format = "[%datetime%] %level_name%: %message% %context%\n";
29			$stream = new StreamHandler($this->appMeta->logDir . '/app.log');
30			$stream->setFormatter(new LineFormatter($format));
31
32			return new Logger($this->appMeta->name, [$stream]);
			0 ignored issues – show Bug Best Practice introduced 2022-03-20 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return new Monolog\Logge...->name, array($stream))` returns the type `Monolog\Logger` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
33			}
34			}
35

bearsunday / BEAR.Package

Issues (74)

src/Provide/Logger/MonologProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like