Issues in ProdMonologProvider.php (1.x) - Issues in 1.x - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

src/Provide/Logger/ProdMonologProvider.php (1 issue)

Labels

Best Practice 1
Bug 1

Severity

Major 1

<?php

declare(strict_types=1);

namespace BEAR\Package\Provide\Logger;

use BEAR\AppMeta\AbstractAppMeta;
use Monolog\Handler\ErrorLogHandler;
use Monolog\Logger;
use Ray\Di\ProviderInterface;

/** @implements ProviderInterface<Logger> */
class ProdMonologProvider implements ProviderInterface
{
    public function __construct(
        private AbstractAppMeta $appMeta,
    ) {
    }

    public function get(): Logger
    {
        return new Logger($this->appMeta->name, [new ErrorLogHandler()]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BEAR\Package\Provide\Logger;
6
7		use BEAR\AppMeta\AbstractAppMeta;
8		use Monolog\Handler\ErrorLogHandler;
9		use Monolog\Logger;
10		use Ray\Di\ProviderInterface;
11
12		/** @implements ProviderInterface<Logger> */
13		class ProdMonologProvider implements ProviderInterface
14		{
15		public function __construct(
16		private AbstractAppMeta $appMeta,
17		) {
18		}
19	8
20		public function get(): Logger
21	8	{
22	8	return new Logger($this->appMeta->name, [new ErrorLogHandler()]);
		0 ignored issues – show Bug Best Practice introduced 2022-03-20 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return new Monolog\Logge...ler\ErrorLogHandler()))` returns the type `Monolog\Logger` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
23		}
24		}
25

bearsunday / BEAR.Package

Issues (36)

src/Provide/Logger/ProdMonologProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like