Issues in MonologProvider.php (1.x) - Issues in 1.x - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

src/Provide/Logger/MonologProvider.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace BEAR\Package\Provide\Logger;

use BEAR\AppMeta\AbstractAppMeta;
use Monolog\Formatter\LineFormatter;
use Monolog\Handler\StreamHandler;
use Monolog\Logger;
use Ray\Di\ProviderInterface;

/** @implements ProviderInterface<Logger> */
class MonologProvider implements ProviderInterface
{
    public function __construct(
        private AbstractAppMeta $appMeta,
    ) {
    }

    /**
     * {@inheritDoc}
     */
    public function get(): Logger
    {
        $format = "[%datetime%] %level_name%: %message% %context%\n";
        $stream = new StreamHandler($this->appMeta->logDir . '/app.log');
        $stream->setFormatter(new LineFormatter($format));

        return new Logger($this->appMeta->name, [$stream]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BEAR\Package\Provide\Logger;
6
7		use BEAR\AppMeta\AbstractAppMeta;
8		use Monolog\Formatter\LineFormatter;
9		use Monolog\Handler\StreamHandler;
10		use Monolog\Logger;
11		use Ray\Di\ProviderInterface;
12
13		/** @implements ProviderInterface<Logger> */
14		class MonologProvider implements ProviderInterface
15		{
16		public function __construct(
17		private AbstractAppMeta $appMeta,
18		) {
19	5	}
20
21	5	/**
22	5	* {@inheritDoc}
23		*/
24		public function get(): Logger
25		{
26		$format = "[%datetime%] %level_name%: %message% %context%\n";
27	5	$stream = new StreamHandler($this->appMeta->logDir . '/app.log');
28		$stream->setFormatter(new LineFormatter($format));
29	5
30		return new Logger($this->appMeta->name, [$stream]);
		0 ignored issues – show Bug Best Practice introduced 2022-03-20 01:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return new Monolog\Logge...->name, array($stream))` returns the type `Monolog\Logger` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
31		}
32		}
33

bearsunday / BEAR.Package

Issues (36)

src/Provide/Logger/MonologProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like