bearsunday / BEAR.Package

src/Bootstrap/Bootstrap.php

Unused Use Statements -2 removed lines

@@ -9,8 +9,6 @@
 use Composer\Autoload\ClassLoader;
 use Doctrine\Common\Annotations\AnnotationRegistry;
 use Doctrine\Common\Annotations\AnnotationReader;
-use Doctrine\Common\Cache\ApcCache;
-use Doctrine\Common\Cache\FilesystemCache;
 use BEAR\Package\Module\Di\DiCompilerProvider;
 use Doctrine\Common\Cache\Cache;
 

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
     public static function registerLoader(ClassLoader $loader, $appName, $appDir)
     {
         /** @var $loader \Composer\Autoload\ClassLoader */
-        $loader->addPsr4($appName . '\\', $appDir . '/src');
+        $loader->addPsr4($appName.'\\', $appDir.'/src');
 
         AnnotationRegistry::registerLoader([$loader, 'loadClass']);
         AnnotationReader::addGlobalIgnoredName('noinspection');
@@ -61,8 +61,8 @@ 
             apc_clear_cache();
         }
 
-        $unlink = function ($path) use (&$unlink) {
-            foreach (glob(rtrim($path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . '*') as $file) {
+        $unlink = function($path) use (&$unlink) {
+            foreach (glob(rtrim($path, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.'*') as $file) {
                 is_dir($file) ? $unlink($file) : unlink($file);
                 @rmdir($file);
             }
@@ -70,6 +70,6 @@ 
         foreach ($dirs as $dir) {
             $unlink($dir);
         }
-        $unlink(dirname(__DIR__) . '/var/tmp');
+        $unlink(dirname(__DIR__).'/var/tmp');
     }
 }

src/Dev/Application/ApplicationReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
     /**
      * @param string $uri
      *
-     * @return array      [$filePath, $fileContents]
+     * @return string[]      [$filePath, $fileContents]
      * @throws InvalidUri
      */
     public function getNewResource($uri)

Spacing +8 added lines, -8 removed lines

@@ -76,7 +76,7 @@ 
     private function getResourcesUris()
     {
         $resources = [];
-        $resourceDir = $this->appDir . '/Resource';
+        $resourceDir = $this->appDir.'/Resource';
         $iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($resourceDir), RecursiveIteratorIterator::SELF_FIRST);
         foreach ($iterator as $item) {
             /** @var $item \SplFileInfo */
@@ -99,11 +99,11 @@ 
      */
     private function getUri(\SplFileInfo $file, $resourceDir)
     {
-        $relativePath = strtolower(str_replace($resourceDir . '/', '', (string) $file));
+        $relativePath = strtolower(str_replace($resourceDir.'/', '', (string) $file));
         $path = explode('/', $relativePath);
         $scheme = array_shift($path);
         $appName = 'self';
-        $uri = "{$scheme}://{$appName}/" . implode('/', $path);
+        $uri = "{$scheme}://{$appName}/".implode('/', $path);
         $uri = substr($uri, 0, -4);
 
         return $uri;
@@ -140,16 +140,16 @@ 
         $path = implode('/', array_map('ucwords', explode('/', $path)));
         $path = str_replace('//', '/', $path);
         // cut head /
-        $filePath = $this->appDir . '/Resource/' . ucwords($url['scheme']) . $path . '.php';
-        $fileContents = file_get_contents(__DIR__ . '/resource.tpl');
+        $filePath = $this->appDir.'/Resource/'.ucwords($url['scheme']).$path.'.php';
+        $fileContents = file_get_contents(__DIR__.'/resource.tpl');
         $fileContents = str_replace('{$app}', $this->appName, $fileContents);
-        $paths = explode('/', $this->appName . $path);
+        $paths = explode('/', $this->appName.$path);
         $class = array_pop($paths);
         $appName = array_shift($paths);
         $scheme = ucwords($url['scheme']);
         $namespace = "{$appName}\\Resource\\{$scheme}";
         if (count($paths) > 0) {
-            $namespace .= '\\' . implode('\\', $paths);
+            $namespace .= '\\'.implode('\\', $paths);
         }
         $fileContents = str_replace('{$namespace}', $namespace, $fileContents);
         $fileContents = str_replace('{$class}', $class, $fileContents);
@@ -205,7 +205,7 @@ 
         }
         $params = [];
         foreach ($allow as $method) {
-            $refMethod = new \ReflectionMethod($ro, 'on' . $method);
+            $refMethod = new \ReflectionMethod($ro, 'on'.$method);
             $parameters = $refMethod->getParameters();
             $paramArray = [];
             foreach ($parameters as $parameter) {

src/Dev/Debug/ExceptionHandle/ExceptionHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -80,7 +80,7 @@ 
     /**
      * Set response
      *
-     * @param mixed             $exceptionTpl
+     * @param string             $exceptionTpl
      * @param ResponseInterface $response
      * @param ResourceObject    $errorPage
      *
@@ -124,7 +124,7 @@ 
     /**
      * Return error page
      *
-     * @param                               $e
+     * @param                               Exception $e
      * @param \BEAR\Resource\ResourceObject $response
      *
      * @return \BEAR\Resource\ResourceObject
@@ -240,7 +240,7 @@ 
     /**
      * Return log file path
      *
-     * @param $exceptionId
+     * @param string $exceptionId
      *
      * @return string
      */

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use BEAR\Resource\Exception\ResourceNotFound;
 use BEAR\Resource\Exception\Scheme;
 use BEAR\Resource\Exception\Uri;
-use BEAR\Sunday\Exception\LogicException;
 use BEAR\Sunday\Extension\WebResponse\ResponseInterface;
 use BEAR\Sunday\Inject\LogDirInject;
 use Exception;

Spacing +7 added lines, -7 removed lines

@@ -94,7 +94,7 @@ 
     ) {
         $this->viewTemplate = $exceptionTpl;
         $this->response = $response;
-        $this->errorPage = $errorPage ? : new ErrorPage;
+        $this->errorPage = $errorPage ?: new ErrorPage;
     }
 
     /**
@@ -132,7 +132,7 @@ 
      */
     private function buildErrorPage($e, ResourceObject $response)
     {
-        $exceptionId = 'e' . $response->code . '-' . substr(md5((string) $e), 0, 5);
+        $exceptionId = 'e'.$response->code.'-'.substr(md5((string) $e), 0, 5);
         try {
             throw $e;
         } catch (ResourceNotFound $e) {
@@ -179,9 +179,9 @@ 
         }
         $response->headers['X-EXCEPTION-CLASS'] = get_class($e);
         $response->headers['X-EXCEPTION-MESSAGE'] = str_replace(PHP_EOL, ' ', $e->getMessage());
-        $response->headers['X-EXCEPTION-CODE-FILE-LINE'] = '(' . $e->getCode() . ') ' . $e->getFile(
-        ) . ':' . $e->getLine();
-        $previous = $e->getPrevious() ? (get_class($e->getPrevious()) . ': ' . str_replace(
+        $response->headers['X-EXCEPTION-CODE-FILE-LINE'] = '('.$e->getCode().') '.$e->getFile(
+        ).':'.$e->getLine();
+        $previous = $e->getPrevious() ? (get_class($e->getPrevious()).': '.str_replace(
             PHP_EOL,
             ' ',
             $e->getPrevious()->getMessage()
@@ -260,10 +260,10 @@ 
         $data = (string) $e;
         $previousE = $e->getPrevious();
         if ($previousE) {
-            $data .= PHP_EOL . PHP_EOL . '-- Previous Exception --' . PHP_EOL . PHP_EOL;
+            $data .= PHP_EOL.PHP_EOL.'-- Previous Exception --'.PHP_EOL.PHP_EOL;
             $data .= $previousE->getTraceAsString();
         }
-        $data .= PHP_EOL . PHP_EOL . '-- Bindings --' . PHP_EOL . (string) $this->injector;
+        $data .= PHP_EOL.PHP_EOL.'-- Bindings --'.PHP_EOL.(string) $this->injector;
         $file = $this->getLogFilePath($exceptionId);
         if (is_writable($this->logDir)) {
             file_put_contents($file, $data);

src/Module/Cache/Interceptor/CacheUpdater.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Ray\Aop\MethodInterceptor;
 use Ray\Aop\MethodInvocation;
 use Ray\Di\Di\Inject;
-use Ray\Di\Di\Named;
 use ReflectionMethod;
 use Doctrine\Common\Cache\Cache;
 

src/Module/Database/Dbal/Pager.php

Doc Comments +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
      *
      * @param $query
      *
-     * @return mixed
+     * @return string
      */
     public function getPagerQuery($query)
     {

Spacing +3 added lines, -3 removed lines

@@ -58,7 +58,7 @@ 
     {
         $this->db = $db;
 
-        $currentPage = $this->currentPage ? : (isset($_GET[$this->pageKey]) ? $_GET[$this->pageKey] : 1);
+        $currentPage = $this->currentPage ?: (isset($_GET[$this->pageKey]) ? $_GET[$this->pageKey] : 1);
         $this->firstResult = ($currentPage - 1) * $this->maxPerPage;
         $pagerfanta->setMaxPerPage($this->maxPerPage);
         $pagerfanta->setCurrentPage($currentPage, false, true);
@@ -82,8 +82,8 @@ 
      */
     private function getHtml(Pagerfanta $pagerfanta)
     {
-        $view = $this->view ? : new TwitterBootstrapView;
-        $routeGenerator = $this->routeGenerator ? : function ($page) {
+        $view = $this->view ?: new TwitterBootstrapView;
+        $routeGenerator = $this->routeGenerator ?: function($page) {
             return "?{$this->pageKey}={$page}";
         };
         $html = $view->render(

src/Module/Di/DiCompilerProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 
     /**
      * @param string $appName
-     * @param string|string[] $context
+     * @param string $context
      * @param string $tmpDir
      * @param Cache  $cache
      *

Spacing +4 added lines, -4 removed lines

@@ -66,12 +66,12 @@ 
      */
     public function get($extraCacheKey = '')
     {
-        $contextKey = is_array($this->context)? implode('_', $this->context) : $this->context;
-        $saveKey = $this->appName . $contextKey;
+        $contextKey = is_array($this->context) ? implode('_', $this->context) : $this->context;
+        $saveKey = $this->appName.$contextKey;
         if (isset(self::$compiler[$saveKey])) {
             return self::$compiler[$saveKey];
         }
-        $moduleProvider = function () use ($saveKey) {
+        $moduleProvider = function() use ($saveKey) {
             // avoid infinity loop
             if (isset(self::$module[$saveKey])) {
                 return self::$module[$saveKey];
@@ -81,7 +81,7 @@ 
 
             return self::$module[$saveKey];
         };
-        $cacheKey = $this->appName . $contextKey . $extraCacheKey;
+        $cacheKey = $this->appName.$contextKey.$extraCacheKey;
         self::$compiler[$saveKey] = $compiler = DiCompiler::create($moduleProvider, $this->cache, $cacheKey, $this->tmpDir);
 
         return $compiler;

src/Module/Form/AuraForm/AuraFormTrait.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Ray\Aop\MethodInvocation;
 use Aura\Input\Form;
 use Ray\Di\Di\Inject;
-use Ray\Di\Di\Named;
 use Aura\Session\Manager as Session;
 use BEAR\Package\Module\Session\AuraSession\AntiCsrf;
 

src/Module/Resource/ResourceGraphModule.php

Unused Use Statements -3 removed lines

@@ -6,10 +6,7 @@
  */
 namespace BEAR\Package\Module\Resource;
 
-use BEAR\Package\Provide as ProvideModule;
-use BEAR\Sunday\Module as SundayModule;
 use Ray\Di\AbstractModule;
-use Ray\Di\Scope;
 
 class ResourceGraphModule extends AbstractModule
 {

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         $this->bindInterceptor(
             $this->matcher->any(),
             $this->matcher->annotatedWith('BEAR\Sunday\Annotation\ResourceGraph'),
-            [$this->requestInjection(__NAMESPACE__ . '\Interceptor\ResourceGraph')]
+            [$this->requestInjection(__NAMESPACE__.'\Interceptor\ResourceGraph')]
         );
     }
 }

src/Module/Resource/SignalParamProvider.php

Unused Use Statements -2 removed lines

@@ -10,11 +10,9 @@
 use Aura\Signal\Manager;
 use Aura\Signal\ResultCollection;
 use Aura\Signal\ResultFactory;
-use BEAR\Package\Provide as ProvideModule;
 use BEAR\Resource\Param;
 use BEAR\Resource\SignalParameter;
 use BEAR\Resource\ParamProviderInterface;
-use BEAR\Sunday\Module as SundayModule;
 use Ray\Di\InstanceInterface;
 use Ray\Di\ProviderInterface;
 use Ray\Di\Di\Inject;