ExceptionAsString::detail() - Code Metrics - Inspection of "Merge pull request #230 from koriym/injector" - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( ca984d...e868bf )

by Akihito

created 2017-03-13 12:07 UTC

ExceptionAsString::detail() A

↳ Parent: ExceptionAsString

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	13
c	0
b	0
f	0
ccs	8
cts	8
cp	1
rs	9.4285
cc	1
eloc	9
nc	1
nop	2
crap	1

<?php
/**
 * This file is part of the BEAR.Package package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\Package\Provide\Error;

use BEAR\Sunday\Extension\Router\RouterMatch as Request;

class ExceptionAsString
{
    public function summery(\Exception $e, $log)
    {
        return sprintf("\n\n[%s]\n%s\n %s", get_class($e), $e->getMessage(), $log);
    }

    /**
     * @param \Exception $e
     * @param Request    $request
     *
     * @return string
     */
    public function detail(\Exception $e, Request $request)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $eSummery = sprintf(
            "[%s]\n%s\nin file %s on line %s\n\n%s",
            get_class($e),
            $e->getMessage(),
            $e->getFile(),
            $e->getLine(),
            $e->getTraceAsString()
        );

        return sprintf("%s\n%s\n\n%s\n%s", date(DATE_RFC2822), $request, $eSummery, $this->getPhpVariables($_SERVER));
    }

    /**
     * @param array $server
     *
     * @return string
     */
    private function getPhpVariables(array $server)
    {
        if (PHP_SAPI === 'cli') {
            return '';
        }

        return sprintf("\nPHP Variables\n\n\$_SERVER => %s", print_r($server, true)); // @codeCoverageIgnore
    }
}


1		<?php
2		/**
3		* This file is part of the BEAR.Package package.
4		*
5		* @license http://opensource.org/licenses/MIT MIT
6		*/
7		namespace BEAR\Package\Provide\Error;
8
9		use BEAR\Sunday\Extension\Router\RouterMatch as Request;
10
11		class ExceptionAsString
12		{
13	3	public function summery(\Exception $e, $log)
14		{
15	3	return sprintf("\n\n[%s]\n%s\n %s", get_class($e), $e->getMessage(), $log);
16		}
17
18		/**
19		* @param \Exception $e
20		* @param Request $request
21		*
22		* @return string
23		*/
24	3	public function detail(\Exception $e, Request $request)
		1 ignored issue – show Coding Style introduced 2015-12-22 09:40 UTC by Report Bug Copy Issue Report `detail` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25		{
26	3	$eSummery = sprintf(
27	3	"[%s]\n%s\nin file %s on line %s\n\n%s",
28		get_class($e),
29	3	$e->getMessage(),
30	3	$e->getFile(),
31	3	$e->getLine(),
32	3	$e->getTraceAsString()
33		);
34
35	3	return sprintf("%s\n%s\n\n%s\n%s", date(DATE_RFC2822), $request, $eSummery, $this->getPhpVariables($_SERVER));
36		}
37
38		/**
39		* @param array $server
40		*
41		* @return string
42		*/
43	3	private function getPhpVariables(array $server)
44		{
45	3	if (PHP_SAPI === 'cli') {
46	3	return '';
47		}
48
49		return sprintf("\nPHP Variables\n\n\$_SERVER => %s", print_r($server, true)); // @codeCoverageIgnore
50		}
51		}
52

bearsunday / BEAR.Package

Push — 1.x ( ca984d...e868bf )

ExceptionAsString::detail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like