Issues in PackageModule.php - All Issues - Inspection of "Merge pull request #260 from koriym/phpstan" - bearsunday/BEAR.Package - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 64141c...67746d )

by Akihito

created 2018-03-14 10:00 UTC

src/PackageModule.php (7 issues)

Labels

Documentation 7

Severity

Minor 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of the BEAR.Package package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace BEAR\Package;

use BEAR\AppMeta\AbstractAppMeta;
use BEAR\Package\Provide\Error\VndErrorModule;
use BEAR\Package\Provide\Logger\PsrLoggerModule;
use BEAR\Package\Provide\Representation\CreatedResourceModule;
use BEAR\Package\Provide\Router\WebRouterModule;
use BEAR\QueryRepository\QueryRepositoryModule;
use BEAR\Streamer\StreamModule;
use BEAR\Sunday\Module\SundayModule;
use Ray\Di\AbstractModule;

class PackageModule extends AbstractModule
{
    protected $appMeta;

    public function __construct(AbstractAppMeta $appMeta = null)
    {
        unset($appMeta); // for BC
        parent::__construct();
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->install(new QueryRepositoryModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new WebRouterModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new VndErrorModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new PsrLoggerModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new StreamModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new CreatedResourceModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new SundayModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2		/**
3		* This file is part of the BEAR.Package package.
4		*
5		* @license http://opensource.org/licenses/MIT MIT
6		*/
7		namespace BEAR\Package;
8
9		use BEAR\AppMeta\AbstractAppMeta;
10		use BEAR\Package\Provide\Error\VndErrorModule;
11		use BEAR\Package\Provide\Logger\PsrLoggerModule;
12		use BEAR\Package\Provide\Representation\CreatedResourceModule;
13		use BEAR\Package\Provide\Router\WebRouterModule;
14		use BEAR\QueryRepository\QueryRepositoryModule;
15		use BEAR\Streamer\StreamModule;
16		use BEAR\Sunday\Module\SundayModule;
17		use Ray\Di\AbstractModule;
18
19		class PackageModule extends AbstractModule
20		{
21		protected $appMeta;
22
23	24	public function __construct(AbstractAppMeta $appMeta = null)
24		{
25	24	unset($appMeta); // for BC
26	24	parent::__construct();
27	24	}
28
29		/**
30		* {@inheritdoc}
31		*/
32	24	protected function configure()
33		{
34	24	$this->install(new QueryRepositoryModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\QueryRepository\QueryRepositoryModule()` is of type `object<BEAR\QueryReposit...\QueryRepositoryModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35	24	$this->install(new WebRouterModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Package\Provide\Router\WebRouterModule()` is of type `object<BEAR\Package\Prov...Router\WebRouterModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36	24	$this->install(new VndErrorModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Package\Provide\Error\VndErrorModule()` is of type `object<BEAR\Package\Provide\Error\VndErrorModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37	24	$this->install(new PsrLoggerModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Package\Provide\Logger\PsrLoggerModule()` is of type `object<BEAR\Package\Prov...Logger\PsrLoggerModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38	24	$this->install(new StreamModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Streamer\StreamModule()` is of type `object<BEAR\Streamer\StreamModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39	24	$this->install(new CreatedResourceModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Package\Provid...CreatedResourceModule()` is of type `object<BEAR\Package\Prov...\CreatedResourceModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40	24	$this->install(new SundayModule);
		0 ignored issues – show Documentation introduced 2018-03-13 16:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \BEAR\Sunday\Module\SundayModule()` is of type `object<BEAR\Sunday\Module\SundayModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41	24	}
42		}
43

bearsunday / BEAR.Package

Push — 1.x ( 64141c...67746d )

src/PackageModule.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like