TokenManipulator::compareTokens() - Code Metrics - bdp-raymon/laravel-otp - Measure and Improve Code Quality continuously with Scrutinizer

TokenManipulator::compareTokens() A
last analyzed 2021-02-15 12:44 UTC

↳ Parent: TokenManipulator

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php


namespace Alish\LaravelOtp\Drivers;


use Illuminate\Support\Arr;

trait TokenManipulator
{

    protected function hashedToken(string $token): string
    {
        if ($this->shouldHash()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->hash->make($token);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return $token;
    }

    protected function caseManipulatedToken(string $token): string
    {
        return $this->sensitiveCase() ? $token : strtolower($token);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function storableToken(string $token): string
    {
        $token = $this->caseManipulatedToken($token);
        $token = $this->hashedToken($token);

        return $token;
    }

    protected function comparableToken(string $token): string
    {
        $token = $this->caseManipulatedToken($token);

        return $token;
    }

    protected function compareTokens(string $token, ?string $originalToken): bool
    {
        if (!$originalToken) {
            return false;
        }

        $comparableToken = $this->comparableToken($originalToken);

        if ($this->shouldHash()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->hash->check($token, $comparableToken);
        }

        return $token === $comparableToken;
    }

}


1			<?php
2
3
4			namespace Alish\LaravelOtp\Drivers;
5
6
7			use Illuminate\Support\Arr;
8
9			trait TokenManipulator
10			{
11
12			protected function hashedToken(string $token): string
13			{
14			if ($this->shouldHash()) {
			0 ignored issues – show Bug introduced 2020-11-11 13:55 UTC by Report Bug Copy Issue Report It seems like `shouldHash()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15			return $this->hash->make($token);
			0 ignored issues – show Bug introduced 2020-11-11 13:55 UTC by Report Bug Copy Issue Report The property `hash` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			}
17
18			return $token;
19			}
20
21			protected function caseManipulatedToken(string $token): string
22			{
23			return $this->sensitiveCase() ? $token : strtolower($token);
			0 ignored issues – show Bug introduced 2020-11-11 13:55 UTC by Report Bug Copy Issue Report It seems like `sensitiveCase()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			protected function storableToken(string $token): string
27			{
28			$token = $this->caseManipulatedToken($token);
29			$token = $this->hashedToken($token);
30
31			return $token;
32			}
33
34			protected function comparableToken(string $token): string
35			{
36			$token = $this->caseManipulatedToken($token);
37
38			return $token;
39			}
40
41			protected function compareTokens(string $token, ?string $originalToken): bool
42			{
43			if (!$originalToken) {
44			return false;
45			}
46
47			$comparableToken = $this->comparableToken($originalToken);
48
49			if ($this->shouldHash()) {
			0 ignored issues – show Bug introduced 2020-11-11 13:55 UTC by Report Bug Copy Issue Report It seems like `shouldHash()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50			return $this->hash->check($token, $comparableToken);
51			}
52
53			return $token === $comparableToken;
54			}
55
56			}
57

bdp-raymon / laravel-otp

TokenManipulator::compareTokens() A last analyzed 2021-02-15 12:44 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TokenManipulator::compareTokens() A
last analyzed 2021-02-15 12:44 UTC