find_centroid() - Code Metrics - Inspection of "V3" - bdelespierre/php-kmeans - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#34)

by Benjamin

created 2021-09-21 01:57 UTC

find_centroid() A

↳ Parent: Project

Complexity

Conditions	4
Paths	6

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	7
nc	6
nop	1
dl	0
loc	15
rs	10
c	1
b	0
f	0

<?php

/**
 * @param array<float> $a
 * @param array<float> $b
 */
function euclidean_dist(array $a, array $b): float
{
    assert(count($a) == count($b));

    for ($dist = 0, $n = 0; $n < count($a); $n++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
        $dist += pow($a[$n] - $b[$n], 2);
    }

    return sqrt($dist);
}

/**
 * @param array<array<float>> $points
 * @return array<float>
 */
function find_centroid(array $points): array
{
    $centroid = [];

    foreach ($points as $point) {
        foreach ($point as $n => $value) {
            $centroid[$n] = ($centroid[$n] ?? 0) + $value;
        }
    }

    foreach ($centroid as &$value) {
        $value /= count($points);
    }

    return $centroid;
}

/**
 * The standard Box–Muller transform generates values from the standard normal
 * distribution (i.e. standard normal deviates).
 *
 * @see https://en.wikipedia.org/wiki/Box%E2%80%93Muller_transform
 *
 * @return array{float, float}

 */
function generate_gaussian_noise(float $mu, float $sigma): array
{
    static $twoPi = 2 * M_PI;

    // create two random numbers, make sure u1 is greater than epsilon
    do {
        $u1 = (float) mt_rand() / (float) mt_getrandmax();
        $u2 = (float) mt_rand() / (float) mt_getrandmax();
    } while ($u1 < PHP_FLOAT_EPSILON);

    // compute z0 and z1
    $mag = $sigma * sqrt(-2.0 * log($u1));
    $z0 = $mag * cos($twoPi * $u2) + $mu;
    $z1 = $mag * sin($twoPi * $u2) + $mu;

    return [$z0, $z1];
}


1			<?php
2
3			/**
4			* @param array<float> $a
5			* @param array<float> $b
6			*/
7			function euclidean_dist(array $a, array $b): float
8			{
9			assert(count($a) == count($b));
10
11			for ($dist = 0, $n = 0; $n < count($a); $n++) {
			0 ignored issues – show Performance Best Practice introduced 2021-09-21 02:09 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
12			$dist += pow($a[$n] - $b[$n], 2);
13			}
14
15			return sqrt($dist);
16			}
17
18			/**
19			* @param array<array<float>> $points
20			* @return array<float>
21			*/
22			function find_centroid(array $points): array
23			{
24			$centroid = [];
25
26			foreach ($points as $point) {
27			foreach ($point as $n => $value) {
28			$centroid[$n] = ($centroid[$n] ?? 0) + $value;
29			}
30			}
31
32			foreach ($centroid as &$value) {
33			$value /= count($points);
34			}
35
36			return $centroid;
37			}
38
39			/**
40			* The standard Box–Muller transform generates values from the standard normal
41			* distribution (i.e. standard normal deviates).
42			*
43			* @see https://en.wikipedia.org/wiki/Box%E2%80%93Muller_transform
44			*
45			* @return array{float, float}
			0 ignored issues – show Documentation Bug introduced 2021-09-21 02:09 UTC by Report Bug Copy Issue Report The doc comment `array{float, float}` at position `2` could not be parsed: Expected ':' at position 2, but found 'float'. Loading history...
46			*/
47			function generate_gaussian_noise(float $mu, float $sigma): array
48			{
49			static $twoPi = 2 * M_PI;
50
51			// create two random numbers, make sure u1 is greater than epsilon
52			do {
53			$u1 = (float) mt_rand() / (float) mt_getrandmax();
54			$u2 = (float) mt_rand() / (float) mt_getrandmax();
55			} while ($u1 < PHP_FLOAT_EPSILON);
56
57			// compute z0 and z1
58			$mag = $sigma * sqrt(-2.0 * log($u1));
59			$z0 = $mag * cos($twoPi * $u2) + $mu;
60			$z1 = $mag * sin($twoPi * $u2) + $mu;
61
62			return [$z0, $z1];
63			}
64

bdelespierre / php-kmeans

Pull Request — master (#34)

find_centroid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like