bdelespierre / php-kmeans

src/Euclidean/Point.php

<?php

namespace Kmeans\Euclidean;

use Kmeans\Concerns\HasDataTrait;
use Kmeans\Concerns\HasSpaceTrait;
use Kmeans\Interfaces\PointInterface;
use Kmeans\Interfaces\SpaceInterface;

class Point implements PointInterface
{
    use HasSpaceTrait;
    use HasDataTrait;

    /**
     * @var array<float>
     */
    private array $coordinates;

    /**
     * @param array<int, float> $coordinates
     */
    public function __construct(SpaceInterface $space, array $coordinates)
    {
        if (! $space instanceof Space) {
            throw new \LogicException(
                "An euclidean point must belong to an euclidean space"
            );
        }

        $this->setSpace($space);
        $this->coordinates = $this->sanitizeCoordinates($coordinates);
    }

    public function getCoordinates(): array
    {
        return $this->coordinates;
    }

    /**
     * @param array<float> $coordinates
     * @return array<float>
     */
    private function sanitizeCoordinates(array $coordinates): array
    {
        assert($this->space instanceof Space);
        if (count($coordinates) != $this->space->getDimensions()) {

The method getDimensions() does not exist on Kmeans\Interfaces\SpaceInterface. It seems like you code against a sub-type of Kmeans\Interfaces\SpaceInterface such as Kmeans\Euclidean\Space.

            throw new \InvalidArgumentException(sprintf(
                "Invalid set of coordinates: %d coordinates expected, %d given",
                $this->space->getDimensions(),
                count($coordinates)
            ));
        }

        $coordinates = filter_var_array($coordinates, FILTER_VALIDATE_FLOAT);
        assert(is_array($coordinates));
        $errors = array_keys($coordinates, false, true);

        if ($errors) {

The expression $errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new \InvalidArgumentException(sprintf(
                "Invalid set of coordinates: values at offsets [%s] could not be converted to numbers",
                implode(',', $errors)
            ));
        }

        return $coordinates;
    }
}