Kmeans\Euclidean\Point::sanitizeCoordinates()

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function sanitizeCoordinates(array $coordinates): array
    {
        assert($this->space instanceof Space);
        if (count($coordinates) != $this->space->getDimensions()) {

The method getDimensions() does not exist on Kmeans\Interfaces\SpaceInterface. It seems like you code against a sub-type of Kmeans\Interfaces\SpaceInterface such as Kmeans\Euclidean\Space.

            throw new \InvalidArgumentException(sprintf(
                "Invalid set of coordinates: %d coordinates expected, %d given",
                $this->space->getDimensions(),
                count($coordinates)
            ));
        }

        $coordinates = filter_var_array($coordinates, FILTER_VALIDATE_FLOAT);
        assert(is_array($coordinates));
        $errors = array_keys($coordinates, false, true);

        if ($errors) {

The expression $errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new \InvalidArgumentException(sprintf(
                "Invalid set of coordinates: values at offsets [%s] could not be converted to numbers",
                implode(',', $errors)
            ));
        }

        return $coordinates;
    }