SettingsForm::__construct() - Code Metrics - Inspection of "Merge branch 'release' into 'master'" - bb-drummer/my-application - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 700b0f...aafb0a )

by Björn

created 2021-02-20 02:06 UTC

SettingsForm::__construct() B

↳ Parent: SettingsForm

Complexity

Conditions	1
Paths	1

Size

Total Lines

101

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	101
ccs	0
cts	22
cp	0
rs	8
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

How to fix Long Method

<?php
/**
 * BB's Zend Framework 2 Components
 * 
 * AdminModule
 *
 * @package   [MyApplication]
 * @package   BB's Zend Framework 2 Components
 * @package   AdminModule
 * @author    Björn Bartels <[email protected]>
 * @link      https://gitlab.bjoernbartels.earth/groups/zf2
 * @license   http://www.apache.org/licenses/LICENSE-2.0 Apache License, Version 2.0
 * @copyright copyright (c) 2016 Björn Bartels <[email protected]>
 */

namespace Admin\Form;

use Zend\Form\Form;
use Admin\Module;

class SettingsForm extends Form
{
    public function __construct($name = null)
    {
        
        // we want to ignore the name passed
        parent::__construct('settings');
        $oModule = new Module();
        $cfg = $oModule->getConfig();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        
        $this->setAttribute('method', 'post');
        $this->add(
            array(
            'name' => 'settings_id',
            'attributes' => array(
            'type'  => 'hidden',
            ),
            )
        );
        $this->add(
            array(
            'name' => 'scope',
            'attributes' => array(
            'type'  => 'text',
            ),
            'options' => array(
            'label' => 'scope',
            ),
            )
        );
        $this->add(
            array(
            'name' => 'ref_id',
            'attributes' => array(
            'type'  => 'text',
            ),
            'options' => array(
            'label' => 'reference',
            ),
            )
        );
        $this->add(
            array(
            'name' => 'type',
            'attributes' => array(
            'type'  => 'text',
            ),
            'options' => array(
            'label' => 'type',
            ),
            )
        );
        $this->add(
            array(
            'name' => 'name',
            'attributes' => array(
            'type'  => 'text',
            ),
            'options' => array(
            'label' => 'name',
            ),
            )
        );
        $this->add(
            array(
            'name' => 'value',
            'attributes' => array(
            'type'  => 'text',
            ),
            'options' => array(
            'label' => 'value',
            ),
            )
        );
        
        $this->add(
            array(
            'name' => 'submit',
            'attributes' => array(
            'type'  => 'submit',
            'value' => 'save',
            'id' => 'submitbutton',
            ),
            'options' => array(
            'label' => 'save',
            ),
            )
        );
        
        $this->add(
            array(
            'name' => 'reset',
            'attributes' => array(
            'type'  => 'reset',
            'value' => 'reset',
            'id' => 'resetbutton',
            ),
            'options' => array(
            'label' => 'reset',
            ),
            )
        );
    }
}

1			<?php
2			/**
3			* BB's Zend Framework 2 Components
4			*
5			* AdminModule
6			*
7			* @package [MyApplication]
8			* @package BB's Zend Framework 2 Components
9			* @package AdminModule
10			* @author Björn Bartels <[email protected]>
11			* @link https://gitlab.bjoernbartels.earth/groups/zf2
12			* @license http://www.apache.org/licenses/LICENSE-2.0 Apache License, Version 2.0
13			* @copyright copyright (c) 2016 Björn Bartels <[email protected]>
14			*/
15
16			namespace Admin\Form;
17
18			use Zend\Form\Form;
19			use Admin\Module;
20
21			class SettingsForm extends Form
22			{
23			public function __construct($name = null)
24			{
25
26			// we want to ignore the name passed
27			parent::__construct('settings');
28			$oModule = new Module();
29			$cfg = $oModule->getConfig();
			0 ignored issues – show Unused Code introduced 2016-08-09 09:57 UTC by Report Bug Copy Issue Report `$cfg` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
30
31			$this->setAttribute('method', 'post');
32			$this->add(
33			array(
34			'name' => 'settings_id',
35			'attributes' => array(
36			'type' => 'hidden',
37			),
38			)
39			);
40			$this->add(
41			array(
42			'name' => 'scope',
43			'attributes' => array(
44			'type' => 'text',
45			),
46			'options' => array(
47			'label' => 'scope',
48			),
49			)
50			);
51			$this->add(
52			array(
53			'name' => 'ref_id',
54			'attributes' => array(
55			'type' => 'text',
56			),
57			'options' => array(
58			'label' => 'reference',
59			),
60			)
61			);
62			$this->add(
63			array(
64			'name' => 'type',
65			'attributes' => array(
66			'type' => 'text',
67			),
68			'options' => array(
69			'label' => 'type',
70			),
71			)
72			);
73			$this->add(
74			array(
75			'name' => 'name',
76			'attributes' => array(
77			'type' => 'text',
78			),
79			'options' => array(
80			'label' => 'name',
81			),
82			)
83			);
84			$this->add(
85			array(
86			'name' => 'value',
87			'attributes' => array(
88			'type' => 'text',
89			),
90			'options' => array(
91			'label' => 'value',
92			),
93			)
94			);
95
96			$this->add(
97			array(
98			'name' => 'submit',
99			'attributes' => array(
100			'type' => 'submit',
101			'value' => 'save',
102			'id' => 'submitbutton',
103			),
104			'options' => array(
105			'label' => 'save',
106			),
107			)
108			);
109
110			$this->add(
111			array(
112			'name' => 'reset',
113			'attributes' => array(
114			'type' => 'reset',
115			'value' => 'reset',
116			'id' => 'resetbutton',
117			),
118			'options' => array(
119			'label' => 'reset',
120			),
121			)
122			);
123			}
124			}

bb-drummer / my-application

Push — master ( 700b0f...aafb0a )

SettingsForm::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like