Application\Controller\SetupController::updatedbAction()

Complexity

Conditions	14
Paths	341

Size

Total Lines	84
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	210

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function updatedbAction()
    {

        echo 'update database structure...' . PHP_EOL;
        
        $request = $this->getRequest();
        $db = $this->getServiceLocator()->get('Zend\Db\Adapter\Adapter');
        $config = $this->getServiceLocator()->get('Config');
        
        // Make sure that we are running in a console and the user has not tricked our
        // application into running this action from a public web server.
        if (!$request instanceof ConsoleRequest) {
            throw new \RuntimeException('You can only use this action from a console!');
        }
        $result = '';

The assignment to $result is dead and can be removed.

        $only_testing = $request->getParam('test', false);

false of type false is incompatible with the type string expected by parameter $default of Zend\Console\Request::getParam().

        $be_verbose = $request->getParam('verbose', false);

        if ($be_verbose) { echo 'current path: ' . getcwd() . PHP_EOL; 
        }
        
        // get tables
        $sql = $db->query("SHOW TABLES;");
        $tables = $sql->execute();
        $tableQueries = array();
        foreach ($tables as $table) { //while ($table = $tables->current()) {
            $tableName = $table["Tables_in_".$config["db"]["database"]];
             // describe tables
            $tableSql = $db->query("SHOW CREATE TABLE `" . $tableName . "`;");
            $tableCreate = $tableSql->execute();
            $tableSpec = $tableCreate->current();
            $tableQueries[] = $tableSpec["Create Table"].";";
        }
        $currentStructure = implode("\n", $tableQueries);
        
        // read INSTALL.SQL
        $filename = getcwd() ."". "/sql/install.sql";
        $installSQL = file_get_contents($filename);
        //file_put_contents(getcwd() ."". "/sql/current.sql", $currentStructure);
        
        // compare SQLs
        try {
            $structureUpdater = new DbStructUpdater();
            $compareResult = $structureUpdater->getUpdates($currentStructure, $installSQL);
            //$compareResult = $structureUpdater->getUpdates($installSQL, $currentStructure);
        } catch (\Exception $ex) {
            echo 'ERROR COMPARING DATABASE STRUCTURE! ' . PHP_EOL;
            if ($be_verbose) { echo 'EXCEPTION: ' . PHP_EOL . print_r($ex, true) . PHP_EOL; 

Are you sure print_r($ex, true) of type string|true can be used in concatenation?

            }
        }
        if (!is_array($compareResult) || (count($compareResult) < 1) ) {

The variable $compareResult does not seem to be defined for all execution paths leading up to this point.

            echo '...database is up-to-date, no actions needed.' . PHP_EOL;
            return 0;
        }
            
        // transaction(!): update db
        
        if ($only_testing) {
            echo 'testing mode...' . PHP_EOL;
            echo 'detected sql update statements:' . PHP_EOL;
            echo  implode(";\n", $compareResult).";" . PHP_EOL;
        } else {
            try {
                $dbConnection = $db->getDriver()->getConnection();
                $dbConnection->beginTransaction();
                foreach ($compareResult as $updateSql) {
                    if ($be_verbose) { echo 'executing sql: ' . $updateSql . PHP_EOL; 
                    }
                    $dbupdate = $db->query($updateSql);
                    $updateResult = $dbupdate->execute();

The assignment to $updateResult is dead and can be removed.

                    if ($be_verbose) { echo '...done' . PHP_EOL; 
                    }
                }
                $dbConnection->commit();
            } catch (\Exception $ex) {
                $dbConnection->rollback();
                echo 'ERROR COMPARING DATABASE STRUCTURE! ' . PHP_EOL;
                if ($be_verbose) { echo 'EXCEPTION: ' . PHP_EOL . print_r($ex, true) . PHP_EOL; 
                }
            }
        }
        
        return 0;
    }