Admin\Factory\SettingsTableFactory::createService()

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $dbAdapter            = $serviceLocator->get('Zend\Db\Adapter\Adapter');
        $resultSetPrototype    = new ResultSet();
        $resultSetPrototype->setArrayObjectPrototype(new Settings());

new Admin\Model\Settings() of type Admin\Model\Settings is incompatible with the type ArrayObject expected by parameter $arrayObjectPrototype of Zend\Db\ResultSet\ResultSet::setArrayObjectPrototype().

        $tableGateway        = new TableGateway('settings', $dbAdapter, null, $resultSetPrototype);

It seems like $dbAdapter can also be of type array; however, parameter $adapter of Zend\Db\TableGateway\TableGateway::__construct() does only seem to accept Zend\Db\Adapter\AdapterInterface, maybe add an additional type check?

        $table                = new SettingsTable($tableGateway);
        return $table;

The expression return $table returns the type Admin\Model\SettingsTable which is incompatible with the documented return type Admin\Factory\Admin\Model\SettingsTable.

    }
}