bb-drummer /
my-application
| Total Complexity | 41 |
| Total Lines | 365 |
| Duplicated Lines | 0 % |
| Coverage | 26.98% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like UsersController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UsersController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 26 | class UsersController extends BaseActionController |
||
| 27 | { |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var array|\Admin\Model\UserTable |
||
| 31 | */ |
||
| 32 | protected $userTable; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var array|\Admin\Model\AclroleTable |
||
| 36 | */ |
||
| 37 | protected $AclroleTable; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * initialize titles and toolbar items |
||
| 41 | * |
||
| 42 | * {@inheritDoc} |
||
| 43 | * @see \Zend\Mvc\Controller\AbstractActionController::onDispatch() |
||
| 44 | */ |
||
| 45 | public function onDispatch(\Zend\Mvc\MvcEvent $e) |
||
| 46 | { |
||
| 47 | $this->setToolbarItems( |
||
| 48 | array( |
||
| 49 | "index" => array( |
||
| 50 | array( |
||
| 51 | 'label' => 'add user', |
||
| 52 | 'icon' => 'plus', |
||
| 53 | 'class' => 'button btn btn-default small btn-sm btn-cta-xhr cta-xhr-modal', |
||
| 54 | 'route' => 'admin/default', |
||
| 55 | 'controller' => 'users', |
||
| 56 | 'action' => 'add', |
||
| 57 | 'resource' => 'mvc:user', |
||
| 58 | ), |
||
| 59 | ), |
||
| 60 | ) |
||
| 61 | ); |
||
| 62 | $this->setActionTitles( |
||
| 63 | array( |
||
| 64 | 'index' => $this->translate("manage users"), |
||
| 65 | 'add' => $this->translate("add user"), |
||
| 66 | 'edit' => $this->translate("edit user"), |
||
| 67 | 'delete' => $this->translate("delete user"), |
||
| 68 | ) |
||
| 69 | ); |
||
| 70 | return parent::onDispatch($e); |
||
| 71 | } |
||
| 72 | |||
| 73 | /** |
||
| 74 | * list users in a table |
||
| 75 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 76 | */ |
||
| 77 | 1 | public function indexAction() |
|
| 78 | { |
||
| 79 | 1 | $tmplVars = $this->getTemplateVars(); |
|
|
Unused Code
introduced
by
|
|||
| 80 | 1 | $aUserlist = $this->getUserTable()->fetchAll(); |
|
| 81 | 1 | if ( $this->isXHR() ) { |
|
| 82 | $datatablesData = array('data' => $aUserlist->toArray()); |
||
| 83 | $oController = $this; |
||
| 84 | $datatablesData['data'] = array_map( |
||
| 85 | function ($row) use ($oController) { |
||
| 86 | $actions = '<div class="button-group tiny btn-group btn-group-xs">'. |
||
| 87 | '<a class="button btn btn-default tiny btn-xs btn-clean btn-cta-xhr cta-xhr-modal" href="'.$oController->url()->fromRoute( |
||
| 88 | 'admin/default', |
||
| 89 | array('controller'=>'users', 'action'=>'edit', 'user_id' => $row["user_id"]) |
||
| 90 | ).'"><span class="fa fa-pencil"></span> '.$oController->translate("edit").'</a>'. |
||
| 91 | '<a class="button btn btn-default tiny btn-xs btn-clean btn-cta-xhr cta-xhr-modal" href="'.$oController->url()->fromRoute( |
||
| 92 | 'admin/default', |
||
| 93 | array('controller'=>'users', 'action'=>'delete', 'user_id' => $row["user_id"]) |
||
| 94 | ).'"><span class="fa fa-trash-o"></span> '.$oController->translate("delete").'</a>'. |
||
| 95 | '</div>'; |
||
| 96 | $row["password"] = "*********"; |
||
| 97 | $row["_actions_"] = $actions; |
||
| 98 | return $row; |
||
| 99 | }, $datatablesData['data'] |
||
| 100 | ); |
||
| 101 | return $this->getResponse()->setContent(json_encode($datatablesData)); |
||
| 102 | } |
||
| 103 | 1 | return new ViewModel( |
|
| 104 | array( |
||
| 105 | 1 | 'userdata' => $aUserlist, |
|
| 106 | ) |
||
| 107 | ); |
||
| 108 | } |
||
| 109 | |||
| 110 | /** |
||
| 111 | * add user entry |
||
| 112 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 113 | */ |
||
| 114 | 1 | public function addAction() |
|
| 115 | { |
||
| 116 | 1 | $tmplVars = $this->getTemplateVars( |
|
| 117 | array( |
||
| 118 | 1 | 'showForm' => true, |
|
| 119 | ) |
||
| 120 | ); |
||
| 121 | 1 | $form = new UserForm(); |
|
| 122 | |||
| 123 | 1 | $roles = $this->getAclroleTable()->fetchAll()->toArray(); |
|
| 124 | 1 | $valueoptions = array(); |
|
| 125 | 1 | foreach ($roles as $role) { |
|
| 126 | 1 | $valueoptions[$role["roleslug"]] = $role["rolename"]; |
|
| 127 | } |
||
| 128 | /** @var \Zend\Form\Element\Select $aclroleSelect */ |
||
| 129 | 1 | $aclroleSelect = $form->get('aclrole'); |
|
| 130 | 1 | $aclroleSelect->setValueOptions($valueoptions); |
|
| 131 | |||
| 132 | 1 | $request = $this->getRequest(); |
|
| 133 | 1 | $user = new User(); |
|
| 134 | 1 | if ($request->isPost()) { |
|
| 135 | $form->setInputFilter($user->getInputFilter()); |
||
| 136 | $form->setData($request->getPost()); |
||
| 137 | |||
| 138 | if ($form->isValid()) { |
||
| 139 | $user->exchangeArray($form->getData()); |
||
| 140 | $this->getUserTable()->saveUser($user); |
||
| 141 | $this->flashMessenger()->addSuccessMessage($this->translate("user has been saved")); |
||
| 142 | if ( $this->isXHR() ) { |
||
| 143 | $tmplVars["showForm"] = false; |
||
| 144 | } else { |
||
| 145 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 146 | } |
||
| 147 | |||
| 148 | } |
||
| 149 | $tmplVars["user"] = $user; |
||
| 150 | } |
||
| 151 | 1 | $tmplVars["form"] = $form; |
|
| 152 | 1 | return new ViewModel($tmplVars); |
|
| 153 | } |
||
| 154 | |||
| 155 | /** |
||
| 156 | * edit user entry |
||
| 157 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 158 | */ |
||
| 159 | 1 | public function editAction() |
|
| 160 | { |
||
| 161 | 1 | $tmplVars = $this->getTemplateVars( |
|
| 162 | array( |
||
| 163 | 1 | 'showForm' => true, |
|
| 164 | ) |
||
| 165 | ); |
||
| 166 | 1 | $id = (int) $this->params()->fromRoute('user_id', 0); |
|
| 167 | 1 | if (!$id) { |
|
| 168 | $this->flashMessenger()->addWarningMessage($this->translate("missing parameters")); |
||
| 169 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 170 | } |
||
| 171 | try { |
||
| 172 | 1 | $user = $this->getUserTable()->getUser($id); |
|
| 173 | } catch (\Exception $e) { |
||
| 174 | $this->flashMessenger()->addWarningMessage($this->translate("invalid parameters")); |
||
| 175 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 176 | } |
||
| 177 | |||
| 178 | 1 | $form = new UserForm(); |
|
| 179 | 1 | $form->bind($user); |
|
| 180 | |||
| 181 | 1 | $roles = $this->getAclroleTable()->fetchAll()->toArray(); |
|
| 182 | 1 | $valueoptions = array(); |
|
| 183 | 1 | foreach ($roles as $role) { |
|
| 184 | 1 | $valueoptions[$role["roleslug"]] = $role["rolename"]; |
|
| 185 | } |
||
| 186 | 1 | $form->get('aclrole')->setValueOptions($valueoptions); |
|
| 187 | |||
| 188 | 1 | $request = $this->getRequest(); |
|
| 189 | 1 | if ($request->isPost()) { |
|
| 190 | $form->setInputFilter($user->getInputFilter()); |
||
| 191 | $form->setData($request->getPost()); |
||
| 192 | if ($form->isValid()) { |
||
| 193 | $this->getUserTable()->saveUser($user); |
||
| 194 | $this->flashMessenger()->addSuccessMessage($this->translate("user has been saved")); |
||
| 195 | if ( $this->isXHR() ) { |
||
| 196 | $tmplVars["showForm"] = false; |
||
| 197 | } else { |
||
| 198 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 199 | } |
||
| 200 | } |
||
| 201 | } else { |
||
| 202 | 1 | $form->bind($user); |
|
| 203 | } |
||
| 204 | 1 | $tmplVars["user_id"] = $id; |
|
| 205 | 1 | $tmplVars["form"] = $form; |
|
| 206 | 1 | return new ViewModel($tmplVars); |
|
| 207 | } |
||
| 208 | |||
| 209 | /** |
||
| 210 | * delete user entry |
||
| 211 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 212 | */ |
||
| 213 | 1 | public function deleteAction() |
|
| 214 | { |
||
| 215 | 1 | $tmplVars = $this->getTemplateVars( |
|
| 216 | array( |
||
| 217 | 1 | 'showForm' => true, |
|
| 218 | ) |
||
| 219 | ); |
||
| 220 | 1 | $id = (int) $this->params()->fromRoute('user_id', 0); |
|
| 221 | 1 | if (!$id) { |
|
| 222 | $this->flashMessenger()->addWarningMessage($this->translate("missing parameters")); |
||
| 223 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 224 | } |
||
| 225 | |||
| 226 | 1 | $tmplVars["user_id"] = $id; |
|
| 227 | try { |
||
| 228 | 1 | $user = $this->getUserTable()->getUser($id); |
|
| 229 | } catch (\Exception $e) { |
||
| 230 | $this->flashMessenger()->addWarningMessage($this->translate("invalid parameters")); |
||
| 231 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 232 | } |
||
| 233 | 1 | $tmplVars["user"] = $user; |
|
| 234 | |||
| 235 | 1 | $request = $this->getRequest(); |
|
| 236 | 1 | if ($request->isPost()) { |
|
| 237 | $del = $request->getPost('del', ''); |
||
| 238 | |||
| 239 | if (!empty($del)) { |
||
| 240 | $id = (int) $request->getPost('id'); |
||
| 241 | $this->getUserTable()->deleteUser($id); |
||
| 242 | $this->flashMessenger()->addSuccessMessage($this->translate("user has been deleted")); |
||
| 243 | if ( $this->isXHR() ) { |
||
| 244 | $tmplVars["showForm"] = false; |
||
| 245 | } else { |
||
| 246 | return $this->redirect()->toRoute('admin/default', array('controller' => 'users')); |
||
| 247 | } |
||
| 248 | } |
||
| 249 | |||
| 250 | } |
||
| 251 | 1 | return new ViewModel($tmplVars); |
|
| 252 | } |
||
| 253 | |||
| 254 | /** |
||
| 255 | * confirm user registration |
||
| 256 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 257 | */ |
||
| 258 | public function confirmAction() |
||
| 309 | } |
||
| 310 | |||
| 311 | } |
||
| 312 | |||
| 313 | /** |
||
| 314 | * active user registration |
||
| 315 | * @return mixed|\Zend\Http\Response|\Zend\View\Model\ViewModel |
||
| 316 | */ |
||
| 317 | public function activateAction() |
||
| 364 | |||
| 365 | } |
||
| 366 | |||
| 367 | /** |
||
| 368 | * retrieve user data table |
||
| 369 | * @return array|\Admin\Model\UserTable |
||
| 370 | */ |
||
| 371 | public function getUserTable() |
||
| 372 | { |
||
| 373 | if (!$this->userTable) { |
||
| 374 | $sm = $this->getServiceLocator(); |
||
| 375 | $this->userTable = $sm->get('AdminUserTable'); |
||
| 376 | } |
||
| 377 | return $this->userTable; |
||
| 378 | } |
||
| 379 | |||
| 380 | /** |
||
| 381 | * retrieve role item table |
||
| 382 | * @return array|\Admin\Model\AclroleTable |
||
| 383 | */ |
||
| 384 | public function getAclroleTable() |
||
| 391 | } |
||
| 392 | |||
| 394 |
Loading history...
