bazzline / php_component_apache_status_parser

example/remote/parse_all.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 8.

/**
 * @author stev leibelt <artodeto@bazzline.net>
 * @since 2017-01-31
 */
use Net\Bazzline\Component\ApacheServerStatusParser\DomainModel\ReduceDataAbleToArrayInterface;

require __DIR__ . '/../../vendor/autoload.php';

//begin of helper functions
/**
 * @param array $array
 * @param string $prefix
 */
function dumpArray(array $array, $prefix = '  ')

The function dumpArray() has been defined more than once; this definition is ignored, only the first definition in example/local/parse_all.php (L15-28) is considered.

This function seems to be duplicated in your project.

{
    foreach ($array as $item => $value) {
        if ($value instanceof ReduceDataAbleToArrayInterface) {
            echo $prefix . $item . PHP_EOL;
            dumpArray($value->reduceDataToArray(), str_repeat($prefix, 2));
        } else if (is_array($value)) {
            echo $prefix . $item . PHP_EOL;
            dumpArray($value, str_repeat($prefix, 2));
        } else {
            echo $prefix . $item . ': ' . $value . PHP_EOL;
        }
    }
}

/**
 * @param array $lines
 * @param string $name
 */
function dumpSectionIfThereIsSomeContent(array $lines, $name)

The function dumpSectionIfThereIsSomeContent() has been defined more than once; this definition is ignored, only the first definition in example/local/parse_all.php (L34-44) is considered.

This function seems to be duplicated in your project.

{
    if (!empty($lines)) {
        echo '==== ' . $name . ' ====' . PHP_EOL;
        echo PHP_EOL;

        dumpArray($lines);

        echo PHP_EOL;
    }
}
//end of helper functions

//begin of dependencies
$listOfNameToElapsedTime    = [];
$parserBuilderFactory       = new \Net\Bazzline\Component\ApacheServerStatusParser\Service\Builder\ParserBuilderFactory();
$storageBuilder             = new \Net\Bazzline\Component\ApacheServerStatusParser\Service\Builder\RemoteStorageBuilder();
$urlToTheExampleFile        = (
    ($argc > 1)
        ? $argv[1]
        : 'http://testdata.bazzline.net/apache_server_status/index.html'
);

$parserBuilder  = $parserBuilderFactory->create();
//end of dependencies

//begin of business logic
PHP_Timer::start();

$storageBuilder->setUrlToTheApacheStatusFileToParseUpfront($urlToTheExampleFile);
$storageBuilder->selectParseModeAllUpfront();
$storageBuilder->build();

$listOfNameToElapsedTime['fetching']    = PHP_Timer::secondsToTimeString(
    PHP_Timer::stop()
);

$storage    = $storageBuilder->andGetStorageAfterTheBuild();

dumpSectionIfThereIsSomeContent($storage->getListOfInformation(), 'Information');
dumpSectionIfThereIsSomeContent($storage->getListOfDetail(), 'Detail');
dumpSectionIfThereIsSomeContent($storage->getListOfScoreboard(), 'Scoreboard');
dumpSectionIfThereIsSomeContent($storage->getListOfStatistic(), 'Statistic');

PHP_Timer::start();

$parserBuilder->setStorageUpfront($storage);
$parserBuilder->build();

$listOfNameToElapsedTime['parsing']    = PHP_Timer::secondsToTimeString(
    PHP_Timer::stop()
);

dumpSectionIfThereIsSomeContent(
    $parserBuilder->andGetListOfDetailOrNullAfterwards(),

It seems like $parserBuilder->andGetListOfDetailOrNullAfterwards() targeting Net\Bazzline\Component\ApacheServerStatusParser\Service\Builder\ParserBuilder::andGetListOfDetailOrNullAfterwards() can also be of type null; however, dumpSectionIfThereIsSomeContent() does only seem to accept array, maybe add an additional type check?

    'Parsed Detail'
);

dumpSectionIfThereIsSomeContent(
    [
        $parserBuilder->andGetInformationOrNullAfterwards()
    ],
    'Parsed Information'
);

dumpSectionIfThereIsSomeContent(
    [
        $parserBuilder->andGetScoreboardOrNullAfterwards()
    ],
    'Parsed Scoreboard'
);

dumpSectionIfThereIsSomeContent(
    [
        $parserBuilder->andGetStatisticOrNullAfterwards()
    ],
    'Parsed Statistic'
);

foreach ($listOfNameToElapsedTime as $name => $elapsedTime) {
    echo $name . ' took: ' . $elapsedTime . PHP_EOL;
}
//end of business logic