Rule::__construct() - Code Metrics - Inspection of "Version 2.0; Global Refactor Code (GRC)" - bavix/router - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Бабичев

created 2018-05-29 15:33 UTC

Rule::__construct() A

↳ Parent: Rule

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	3
dl	0
loc	7
ccs	0
cts	6
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Bavix\Router;

abstract class Rule
{

    use Attachable;

    /**
     * @var null|string
     */
    protected $type;

    /**
     * @var null|Path
     */
    protected $path;

    /**
     * @var array
     */
    protected $methods;

    /**
     * @var array
     */
    protected $defaults;

    /**
     * Rule constructor.
     *
     * @param string $key
     * @param array $storage
     * @param null|self $parent
     */
    public function __construct(string $key, array $storage, ?self $parent = null)
    {
        $this->prepare();
        $this->initializer($key, $storage);
        $this->pathInit();
        if ($parent) {
            $this->afterPrepare($parent);
        }
    }

    /**
     * @param Path|null $path
     */
    protected function hinge(?Path $path): void
    {
        if ($this->path && $path) {
            $this->path->hinge($path);
            return;
        }

        $this->path = $path ?? $this->path;
    }

    /**
     * @param self $parent
     * @return void
     */
    protected function afterPrepare(self $parent): void
    {
        $this->hinge($parent->path);
        $this->_key = $parent->_key . '.' . $this->_key;
        $this->methods = $this->methods ?? $parent->methods;
        $this->defaults = \array_merge(
            (array)$parent->defaults,
            (array)$this->defaults
        );
    }

    /**
     * if this.path === string then new Path(string, [])
     * else this.path === array then new Path(...this.path)
     */
    protected function pathInit(): void
    {
        if (\is_string($this->path)) {

            $this->path = new Path($this->path);
        } elseif (\is_array($this->path)) {

            $this->path = new Path(...$this->path);
        }
    }

    /**
     * @return void
     */
    protected function prepare(): void
    {
        // todo: a lot of logic
    }

}


1			<?php
2
3			namespace Bavix\Router;
4
5			abstract class Rule
6			{
7
8			use Attachable;
9
10			/**
11			* @var null\|string
12			*/
13			protected $type;
14
15			/**
16			* @var null\|Path
17			*/
18			protected $path;
19
20			/**
21			* @var array
22			*/
23			protected $methods;
24
25			/**
26			* @var array
27			*/
28			protected $defaults;
29
30			/**
31			* Rule constructor.
32			*
33			* @param string $key
34			* @param array $storage
35			* @param null\|self $parent
36			*/
37			public function __construct(string $key, array $storage, ?self $parent = null)
38			{
39			$this->prepare();
40			$this->initializer($key, $storage);
41			$this->pathInit();
42			if ($parent) {
43			$this->afterPrepare($parent);
44			}
45			}
46
47			/**
48			* @param Path\|null $path
49			*/
50			protected function hinge(?Path $path): void
51			{
52			if ($this->path && $path) {
53			$this->path->hinge($path);
54			return;
55			}
56
57			$this->path = $path ?? $this->path;
58			}
59
60			/**
61			* @param self $parent
62			* @return void
63			*/
64			protected function afterPrepare(self $parent): void
65			{
66			$this->hinge($parent->path);
67			$this->_key = $parent->_key . '.' . $this->_key;
68			$this->methods = $this->methods ?? $parent->methods;
69			$this->defaults = \array_merge(
70			(array)$parent->defaults,
71			(array)$this->defaults
72			);
73			}
74
75			/**
76			* if this.path === string then new Path(string, [])
77			* else this.path === array then new Path(...this.path)
78			*/
79			protected function pathInit(): void
80			{
81			if (\is_string($this->path)) {
			0 ignored issues – show introduced 2018-05-29 15:37 UTC by Report Bug Copy Issue Report The condition `is_string($this->path)` is always `false`. Loading history...
82			$this->path = new Path($this->path);
83			} elseif (\is_array($this->path)) {
			0 ignored issues – show introduced 2018-05-29 15:37 UTC by Report Bug Copy Issue Report The condition `is_array($this->path)` is always `false`. Loading history...
84			$this->path = new Path(...$this->path);
85			}
86			}
87
88			/**
89			* @return void
90			*/
91			protected function prepare(): void
92			{
93			// todo: a lot of logic
94			}
95
96			}
97

bavix / router

Pull Request — master (#3)

Rule::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like