Bavix\Wallet\Traits\CanConfirm

Complexity

Total Complexity

9

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	1	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	safeConfirm()	0	6	2
A	confirm()	0	21	3
A	forceConfirm()	0	21	4

<?php

namespace Bavix\Wallet\Traits;

use Bavix\Wallet\Exceptions\ConfirmedInvalid;
use Bavix\Wallet\Exceptions\WalletOwnerInvalid;
use Bavix\Wallet\Models\Transaction;
use Bavix\Wallet\Services\CommonService;
use Bavix\Wallet\Services\WalletService;
use Illuminate\Support\Facades\DB;

trait CanConfirm
{


    /**
     * @param Transaction $transaction
     * @return bool
     */
    public function confirm(Transaction $transaction): bool
    {
        $self = $this;
        return DB::transaction(static function() use ($self, $transaction) {
            $wallet = app(WalletService::class)
                ->getWallet($self);

$self of type Bavix\Wallet\Traits\CanConfirm is incompatible with the type Bavix\Wallet\Interfaces\Wallet expected by parameter $object of Bavix\Wallet\Services\WalletService::getWallet().

            if (!$wallet->refreshBalance()) {
                // @codeCoverageIgnoreStart
                return false;
                // @codeCoverageIgnoreEnd
            }

            if ($transaction->type === Transaction::TYPE_WITHDRAW) {
                app(CommonService::class)->verifyWithdraw(
                    $wallet,
                    \abs($transaction->amount)

It seems like abs($transaction->amount) can also be of type double; however, parameter $amount of Bavix\Wallet\Services\CommonService::verifyWithdraw() does only seem to accept integer, maybe add an additional type check?

                );
            }

            return $self->forceConfirm($transaction);
        });
    }

    /**
     * @param Transaction $transaction
     * @return bool
     */
    public function safeConfirm(Transaction $transaction): bool
    {
        try {
            return $this->confirm($transaction);
        } catch (\Throwable $throwable) {
            return false;
        }
    }

    /**
     * @param Transaction $transaction
     * @return bool
     * @throws ConfirmedInvalid
     * @throws WalletOwnerInvalid
     */
    public function forceConfirm(Transaction $transaction): bool
    {
        $self = $this;
        return DB::transaction(static function() use ($self, $transaction) {

            $wallet = app(WalletService::class)
                ->getWallet($self);

$self of type Bavix\Wallet\Traits\CanConfirm is incompatible with the type Bavix\Wallet\Interfaces\Wallet expected by parameter $object of Bavix\Wallet\Services\WalletService::getWallet().

            if ($transaction->confirmed) {
                throw new ConfirmedInvalid(trans('wallet::errors.confirmed_invalid'));

It seems like trans('wallet::errors.confirmed_invalid') can also be of type array; however, parameter $message of Bavix\Wallet\Exceptions\ConfirmedInvalid::__construct() does only seem to accept string, maybe add an additional type check?

            }

            if ($wallet->id !== $transaction->wallet_id) {

The property wallet_id does not exist on Bavix\Wallet\Models\Transaction. Did you mean wallet?

                throw new WalletOwnerInvalid(trans('wallet::errors.owner_invalid'));

It seems like trans('wallet::errors.owner_invalid') can also be of type array; however, parameter $message of Bavix\Wallet\Exceptions\WalletOwnerInvalid::__construct() does only seem to accept string, maybe add an additional type check?

            }

            return $transaction->update(['confirmed' => true]) &&

                // update balance
                app(CommonService::class)
                    ->addBalance($wallet, $transaction->amount);

        });
    }

}