Bavix\Wallet\Simple\MemoryStore

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setBalance()	0	5	1
A	getBalance()	0	9	2
A	incBalance()	0	12	2

<?php

namespace Bavix\Wallet\Simple;

use Bavix\Wallet\Interfaces\Storable;
use Bavix\Wallet\Services\ProxyService;
use Bavix\Wallet\Services\WalletService;

class MemoryStore implements Storable
{

    /**
     * @inheritDoc
     */
    public function getBalance($object): int
    {
        $wallet = app(WalletService::class)->getWallet($object);
        $proxy = app(ProxyService::class);
        if (!$proxy->has($wallet->getKey())) {

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::has() does only seem to accept string, maybe add an additional type check?

            $proxy->set($wallet->getKey(), (int) $wallet->getOriginal('balance', 0));

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

        }

        return $proxy[$wallet->getKey()];
    }

    /**
     * @inheritDoc
     */
    public function incBalance($object, int $amount): int
    {
        $wallet = app(WalletService::class)->getWallet($object);
        $proxy = app(ProxyService::class);
        $balance = $wallet->balance + $amount;

        if ($proxy->has($wallet->getKey())) {

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::has() does only seem to accept string, maybe add an additional type check?

            $balance = $proxy->get($wallet->getKey()) + $amount;

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::get() does only seem to accept string, maybe add an additional type check?

        }

        $this->setBalance($object, $balance);
        return $balance;
    }

    /**
     * @inheritDoc
     */
    public function setBalance($object, int $amount): bool
    {
        $wallet = app(WalletService::class)->getWallet($object);
        $proxy = app(ProxyService::class);
        return (bool)$proxy->set($wallet->getKey(), $amount);

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

    }

}