CommonService::addBalance() - Code Metrics - Inspection of "3.0-Dev: Architecture correction" - bavix/laravel-wallet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

by Бабичев

created 2019-05-17 15:24 UTC

CommonService::addBalance() A

↳ Parent: CommonService

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2.0078

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	2
dl	0
loc	12
ccs	7
cts	8
cp	0.875
crap	2.0078
rs	10
c	0
b	0
f	0

<?php

namespace Bavix\Wallet\Services;

use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Wallet as WalletModel;
use Bavix\Wallet\Objects\Transaction;
use Illuminate\Support\Facades\DB;

class CommonService
{

    /**
     * @param bool $dbTran
     * @param Wallet $self
     * @param Transaction[] $transactions
     * @return \Bavix\Wallet\Models\Transaction[]
     */
    public function enforce(bool $dbTran, Wallet $self, array $transactions): array
    {
        $callback = function () use ($self, $transactions) {
            $objects = [];

            foreach ($transactions as $transaction) {
                if ($transaction->isConfirmed()) {
                    $this->addBalance($self, $transaction->getAmount());
                }

                $objects[] = $transaction->create($self);
            }

            return $objects;
        };

        if ($dbTran) {
            return DB::transaction($callback);
        }

        return $callback();
    }

    /**
     * @param Wallet $wallet
     * @param int $amount
     * @return bool
     */
    public function addBalance(Wallet $wallet, int $amount): bool
    {
        $newBalance = $wallet->getBalanceAttribute() + $amount;
        $wallet->balance = $newBalance;


        if ($wallet->save()) {
        if ($wallet->/** @scrutinizer ignore-call */ save()) {
            $proxy = app(ProxyService::class);
            $proxy->set($wallet->getKey(), $newBalance);
            $proxy->set($wallet->/** @scrutinizer ignore-call */ getKey(), $newBalance);
            return true;
        }

        return false;
    }

}


bavix / laravel-wallet

Pull Request — master (#40)

CommonService::addBalance() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like