Bavix\Wallet\Services\CommonService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addBalance()	0	12	2
A	enforce()	0	21	4

<?php

namespace Bavix\Wallet\Services;

use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Wallet as WalletModel;
use Bavix\Wallet\Objects\Transaction;
use Illuminate\Support\Facades\DB;

class CommonService
{

    /**
     * @param bool $dbTran
     * @param Wallet $self
     * @param Transaction[] $transactions
     * @return \Bavix\Wallet\Models\Transaction[]
     */
    public function enforce(bool $dbTran, Wallet $self, array $transactions): array
    {
        $callback = function () use ($self, $transactions) {
            $objects = [];

            foreach ($transactions as $transaction) {
                if ($transaction->isConfirmed()) {
                    $this->addBalance($self, $transaction->getAmount());
                }

                $objects[] = $transaction->create($self);
            }

            return $objects;
        };

        if ($dbTran) {
            return DB::transaction($callback);
        }

        return $callback();
    }

    /**
     * @param Wallet $wallet
     * @param int $amount
     * @return bool
     */
    public function addBalance(Wallet $wallet, int $amount): bool
    {
        $newBalance = $wallet->getBalanceAttribute() + $amount;
        $wallet->balance = $newBalance;

Accessing balance on the interface Bavix\Wallet\Interfaces\Wallet suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($wallet->save()) {

The method save() does not exist on Bavix\Wallet\Interfaces\Wallet. It seems like you code against a sub-type of said class. However, the method does not exist in Bavix\Wallet\Interfaces\Customer or Bavix\Wallet\Interfaces\Product. Are you sure you never get one of those?

            $proxy = app(ProxyService::class);
            $proxy->set($wallet->getKey(), $newBalance);

The method getKey() does not exist on Bavix\Wallet\Interfaces\Wallet. It seems like you code against a sub-type of said class. However, the method does not exist in Bavix\Wallet\Interfaces\Customer or Bavix\Wallet\Interfaces\Product. Are you sure you never get one of those?

            return true;
        }

        return false;
    }

}