Bavix\Wallet\Services\WalletService

Complexity

Total Complexity

14

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	refresh()	0	10	1
A	getBalance()	0	10	3
A	decimalPlaces()	0	4	2
A	fee()	0	21	4
A	getWallet()	0	10	2
A	checkAmount()	0	4	2

<?php

namespace Bavix\Wallet\Services;

use Bavix\Wallet\Exceptions\AmountInvalid;
use Bavix\Wallet\Interfaces\MinimalTaxable;
use Bavix\Wallet\Interfaces\Taxable;
use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Wallet as WalletModel;
use Bavix\Wallet\Traits\HasWallet;
use function app;

class WalletService
{

    /**
     * @param Wallet $object
     * @return int
     */
    public function decimalPlaces(Wallet $object): int
    {
        $decimalPlaces = $this->getWallet($object)->decimal_places ?: 2;
        return 10 ** $decimalPlaces;
    }

    /**
     * Consider the fee that the system will receive.
     *
     * @param Wallet $wallet
     * @param int $amount
     * @return int
     */
    public function fee(Wallet $wallet, int $amount): int
    {
        $result = 0;

        if ($wallet instanceof Taxable) {
            $result = (int) ($amount * $wallet->getFeePercent() / 100);

            /**
             * Added minimum commission condition
             *
             * @see https://github.com/bavix/laravel-wallet/issues/64#issuecomment-514483143
             */
            if ($wallet instanceof MinimalTaxable) {
                $minimal = $wallet->getMinimalFee();
                if ($result < $minimal) {
                    $result = $wallet->getMinimalFee();
                }
            }
        }

        return $result;
    }

    /**
     * The amount of checks for errors
     *
     * @param int $amount
     * @throws
     */
    public function checkAmount(int $amount): void
    {
        if ($amount < 0) {
            throw new AmountInvalid(trans('wallet::errors.price_positive'));

It seems like trans('wallet::errors.price_positive') can also be of type array; however, parameter $message of Bavix\Wallet\Exceptions\AmountInvalid::__construct() does only seem to accept string, maybe add an additional type check?

        }
    }

    /**
     * @param Wallet $object
     * @return WalletModel
     */
    public function getWallet(Wallet $object): WalletModel
    {
        if ($object instanceof WalletModel) {
            return $object;
        }

        /**
         * @var HasWallet $object
         */
        return $object->wallet;
    }

    /**
     * @param Wallet $object
     * @return int
     */
    public function getBalance(Wallet $object): int
    {
        $wallet = $this->getWallet($object);
        $wallet->exists or $wallet->save();
        $proxy = app(ProxyService::class);
        if (!$proxy->has($wallet->getKey())) {

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::has() does only seem to accept string, maybe add an additional type check?

            $proxy->set($wallet->getKey(), (int) $wallet->getOriginal('balance', 0));

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

        }

        return $proxy[$wallet->getKey()];
    }

    /**
     * @param WalletModel $wallet
     * @return bool
     */
    public function refresh(WalletModel $wallet): bool
    {
        $this->getBalance($wallet);
        $balance = $wallet->getAvailableBalance();
        $wallet->balance = $balance;

        $proxy = app(ProxyService::class);
        $proxy->set($wallet->getKey(), $balance);

It seems like $wallet->getKey() can also be of type boolean and null; however, parameter $key of Bavix\Wallet\Services\ProxyService::set() does only seem to accept string, maybe add an additional type check?

        return $wallet->save();
    }

}