Bavix\Wallet\Traits\HasGift

Complexity

Total Complexity

5

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	6
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	safeGift()	0	6	2
A	gift()	0	45	2
A	forceGift()	0	3	1

<?php

namespace Bavix\Wallet\Traits;

use Bavix\Wallet\Interfaces\Product;
use Bavix\Wallet\Interfaces\Wallet;
use Bavix\Wallet\Models\Transfer;
use Bavix\Wallet\Objects\Bring;
use Bavix\Wallet\Services\CommonService;
use Bavix\Wallet\Services\WalletService;
use Illuminate\Support\Facades\DB;
use Throwable;
use function app;

/**
 * Trait HasGift
 * @package Bavix\Wallet\Traits
 *
 * This trait should be used with the trait HasWallet.
 */
trait HasGift
{

    /**
     * Give the goods safely.
     *
     * @param Wallet $to
     * @param Product $product
     * @param bool $force
     * @return Transfer|null
     */
    public function safeGift(Wallet $to, Product $product, bool $force = null): ?Transfer
    {
        try {
            return $this->gift($to, $product, $force);
        } catch (Throwable $throwable) {
            return null;
        }
    }

    /**
     * From this moment on, each user (wallet) can give
     * the goods to another user (wallet).
     * This functionality can be organized for gifts.
     *
     * @param Wallet $to
     * @param Product $product
     * @param bool $force
     * @return Transfer
     */
    public function gift(Wallet $to, Product $product, bool $force = null): Transfer
    {
        /**
         * Who's giving? Let's call him Santa Claus
         * @var Wallet $santa
         */
        $santa = $this;

        /**
         * Unfortunately,
         * I think it is wrong to make the "assemble" method public.
         * That's why I address him like this!
         */
        return DB::transaction(static function() use ($santa, $to, $product, $force) {
            $amount = $product->getAmountProduct();
            $meta = $product->getMetaProduct();
            $fee = app(WalletService::class)
                ->fee($product, $amount);

            $commonService = app(CommonService::class);

            /**
             * Santa pays taxes
             */
            if (!$force) {

The expression $force of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

                $commonService->verifyWithdraw($santa, $amount);
            }

            $withdraw = $commonService->forceWithdraw($santa, $amount + $fee, $meta);

It seems like $santa can also be of type Bavix\Wallet\Traits\HasWallet; however, parameter $wallet of Bavix\Wallet\Services\CommonService::forceWithdraw() does only seem to accept Bavix\Wallet\Interfaces\Wallet, maybe add an additional type check?

            $deposit = $commonService->deposit($product, $amount, $meta);

            $from = app(WalletService::class)
                ->getWallet($to);

            $transfers = $commonService->assemble([
                (new Bring())
                    ->setStatus(Transfer::STATUS_GIFT)
                    ->setDeposit($deposit)
                    ->setWithdraw($withdraw)
                    ->setFrom($from)
                    ->setTo($product)
            ]);

            return current($transfers);
        });
    }

    /**
     * to give force)
     *
     * @param Wallet $to
     * @param Product $product
     * @return Transfer
     */
    public function forceGift(Wallet $to, Product $product): Transfer
    {
        return $this->gift($to, $product, true);
    }

}