SettingService::delete() - Code Metrics - Inspection of "add delete method" - bavix/laravel-settings - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c22c2e...c08184 )

by Бабичев

created 2019-08-01 10:17 UTC

SettingService::delete() A

↳ Parent: SettingService

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	4
nop	2
dl	0
loc	21
ccs	11
cts	11
cp	1
crap	4
rs	9.9332
c	0
b	0
f	0

<?php

namespace Bavix\Settings\Services;

use Bavix\Settings\Models\Setting;
use Bavix\Settings\Traits\HasSettings;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;

class SettingService
{

    /**
     * @param Model $model
     * @param string $key
     * @param string $cast
     * @param mixed $value
     * @return Setting
     */
    public function create(Model $model, string $key, string $cast, $value): Setting
    {
        /**
         * @var HasSettings $model
         * @var Setting $setting
         */
        $setting = $model->settings()
            ->create(\compact('key', 'cast', 'value'));

        /**
         * @var Collection $collection
         */
        $collection = $model->settings;
        $collection->push($setting);

        return $setting;
    }

    /**
     * @param Model $model
     * @param string $key
     * @return bool
     * @throws
     */
    public function delete(Model $model, string $key): bool
    {
        $setting = app(ReadableService::class)
            ->getSetting($model, $key);

        if ($setting) {
            /**
             * @var Collection $collection
             */
            $collection = $model->settings;
            foreach ($collection as $index => $item) {
                if ($item === $setting) {
                    $collection->forget($index);
                    break;
                }
            }

            return $setting->delete();
        }

        return false;
    }

}


1		<?php
2
3		namespace Bavix\Settings\Services;
4
5		use Bavix\Settings\Models\Setting;
6		use Bavix\Settings\Traits\HasSettings;
7		use Illuminate\Database\Eloquent\Collection;
8		use Illuminate\Database\Eloquent\Model;
9
10		class SettingService
11		{
12
13		/**
14		* @param Model $model
15		* @param string $key
16		* @param string $cast
17		* @param mixed $value
18		* @return Setting
19		*/
20	18	public function create(Model $model, string $key, string $cast, $value): Setting
21		{
22		/**
23		* @var HasSettings $model
24		* @var Setting $setting
25		*/
26	18	$setting = $model->settings()
27	18	->create(\compact('key', 'cast', 'value'));
28
29		/**
30		* @var Collection $collection
31		*/
32	18	$collection = $model->settings;
33	18	$collection->push($setting);
34
35	18	return $setting;
36		}
37
38		/**
39		* @param Model $model
40		* @param string $key
41		* @return bool
42		* @throws
43		*/
44	1	public function delete(Model $model, string $key): bool
45		{
46	1	$setting = app(ReadableService::class)
47	1	->getSetting($model, $key);
48
49	1	if ($setting) {
50		/**
51		* @var Collection $collection
52		*/
53	1	$collection = $model->settings;
54	1	foreach ($collection as $index => $item) {
55	1	if ($item === $setting) {
56	1	$collection->forget($index);
57	1	break;
58		}
59		}
60
61	1	return $setting->delete();
62		}
63
64	1	return false;
65		}
66
67		}
68

bavix / laravel-settings

Push — master ( c22c2e...c08184 )

SettingService::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like