bavix /
advanced-html-dom
| Total Complexity | 66 |
| Total Lines | 319 |
| Duplicated Lines | 0 % |
| Coverage | 49.6% |
| Changes | 0 | ||
Complex classes like AdvancedHtmlBase often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AdvancedHtmlBase, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 5 | class AdvancedHtmlBase |
||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var |
||
| 10 | */ |
||
| 11 | public $doc; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var |
||
| 15 | */ |
||
| 16 | public $dom; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var |
||
| 20 | */ |
||
| 21 | public $node; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var bool |
||
| 25 | */ |
||
| 26 | public $is_text = false; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @see https://github.com/monkeysuffrage/advanced_html_dom/issues/19 |
||
| 30 | */ |
||
| 31 | 2 | public function __destruct() |
|
| 32 | { |
||
| 33 | 2 | $this->doc = $this->dom = $this->node = null; |
|
| 34 | 2 | unset($this->doc, $this->dom, $this->node); |
|
| 35 | 2 | Cleanup::all(); |
|
| 36 | 2 | } |
|
| 37 | |||
| 38 | /** |
||
| 39 | * @return mixed |
||
| 40 | */ |
||
| 41 | 1 | public function text() |
|
| 42 | { |
||
| 43 | 1 | return $this->node->nodeValue; |
|
| 44 | } |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @return mixed |
||
| 48 | */ |
||
| 49 | 3 | public function html() |
|
| 50 | { |
||
| 51 | 3 | return $this->doc->dom->saveHTML($this->node); |
|
| 52 | } |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @return string |
||
| 56 | */ |
||
| 57 | public function __toString() |
||
| 58 | { |
||
| 59 | return (string)$this->html(); |
||
| 60 | } |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @return $this |
||
| 64 | */ |
||
| 65 | public function remove() |
||
| 66 | { |
||
| 67 | $this->node->parentNode->removeChild($this->node); |
||
| 68 | |||
| 69 | return $this; |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @return Str |
||
| 74 | */ |
||
| 75 | public function str() |
||
| 76 | { |
||
| 77 | return new Str($this->text); |
||
|
Bug
Best Practice
introduced
by
|
|||
| 78 | } |
||
| 79 | |||
| 80 | /** |
||
| 81 | * @param $re |
||
| 82 | * |
||
| 83 | * @return bool |
||
| 84 | */ |
||
| 85 | public function match($re) |
||
| 90 | } |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @param $re |
||
| 94 | * |
||
| 95 | * @return mixed |
||
| 96 | */ |
||
| 97 | public function scan($re) |
||
| 98 | { |
||
| 99 | $str = new Str($this->text); |
||
| 100 | |||
| 101 | return $str->scan($re); |
||
| 102 | } |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @param $str |
||
| 106 | * |
||
| 107 | * @return string |
||
| 108 | */ |
||
| 109 | public function clean($str) |
||
| 110 | { |
||
| 111 | return $this->trim(\preg_replace('/\s+/', ' ', $str)); |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param $str |
||
| 116 | * |
||
| 117 | * @return string |
||
| 118 | */ |
||
| 119 | public function trim($str) |
||
| 120 | { |
||
| 121 | return \trim($str); |
||
| 122 | } |
||
| 123 | |||
| 124 | /** |
||
| 125 | * @param $css |
||
| 126 | * @param null $index |
||
| 127 | * |
||
| 128 | * @return array|AHTMLNode|AHTMLNodeList |
||
| 129 | */ |
||
| 130 | 4 | public function find($css, $index = null) |
|
| 152 | } |
||
| 153 | |||
| 154 | // magic methods |
||
| 155 | |||
| 156 | /** |
||
| 157 | * @param $key |
||
| 158 | * @param $args |
||
| 159 | * |
||
| 160 | * @return AHTMLNode[]|AHTMLNodeList|null |
||
| 161 | */ |
||
| 162 | 4 | public function __call($key, $args) |
|
| 163 | { |
||
| 164 | 4 | $key = \strtolower(\str_replace('_', '', $key)); |
|
| 165 | switch ($key) |
||
| 166 | { |
||
| 167 | 4 | case 'innertext': |
|
| 168 | return ($this->is_text || !$this->children->length) ? $this->text() : $this->find('./text()|./*')->outertext; |
||
| 169 | 4 | case 'plaintext': |
|
| 170 | return $this->text(); |
||
| 171 | 4 | case 'outertext': |
|
| 172 | 4 | case 'html': |
|
| 173 | 4 | case 'save': |
|
| 174 | return $this->html(); |
||
| 175 | 4 | case 'innerhtml': |
|
| 176 | $ret = ''; |
||
| 177 | foreach ($this->node->childNodes as $child) |
||
| 178 | { |
||
| 179 | $ret .= $this->doc->dom->saveHTML($child); |
||
| 180 | } |
||
| 181 | |||
| 182 | return $ret; |
||
| 183 | |||
| 184 | 4 | case 'tag': |
|
| 185 | 1 | return $this->node->nodeName; |
|
| 186 | 4 | case 'next': |
|
| 187 | return $this->at('./following-sibling::*[1]|./following-sibling::text()[1]|./following-sibling::comment()[1]'); |
||
| 188 | |||
| 189 | 4 | case 'index': |
|
| 190 | return $this->search('./preceding-sibling::*')->length + 1; |
||
| 191 | |||
| 192 | /* |
||
| 193 | DOMNode::insertBefore — Adds a new child |
||
| 194 | */ |
||
| 195 | |||
| 196 | // simple-html-dom junk methods |
||
| 197 | 4 | case 'clear': |
|
| 198 | return; |
||
| 199 | |||
| 200 | // search functions |
||
| 201 | 4 | case 'at': |
|
| 202 | 1 | case 'getelementbytagname': |
|
| 203 | 4 | return $this->find($args[0], 0); |
|
| 204 | |||
| 205 | 1 | case 'search': |
|
| 206 | 1 | case 'getelementsbytagname': |
|
| 207 | return isset($args[1]) ? $this->find($args[0], $args[1]) : $this->find($args[0]); |
||
| 208 | |||
| 209 | 1 | case 'getelementbyid': |
|
| 210 | return $this->find('#' . $args[0], 0); |
||
| 211 | 1 | case 'getelementsbyid': |
|
| 212 | return isset($args[1]) ? $this->find('#' . $args[0], $args[1]) : $this->find('#' . $args[0]); |
||
| 213 | |||
| 214 | // attributes |
||
| 215 | 1 | case 'hasattribute': |
|
| 216 | return !$this->is_text && $this->node->hasAttribute($args[0]); |
||
| 217 | |||
| 218 | 1 | case 'getattribute': |
|
| 219 | $arg = $args[0]; |
||
| 220 | |||
| 221 | return $this->$arg; |
||
| 222 | 1 | case 'setattribute': |
|
| 223 | $arg0 = $args[0]; |
||
| 224 | $arg1 = $args[1]; |
||
| 225 | |||
| 226 | return $this->$arg0 = $arg1; |
||
| 227 | 1 | case 'removeattribute': |
|
| 228 | $arg = $args[0]; |
||
| 229 | |||
| 230 | return $this->$arg = null; |
||
| 231 | |||
| 232 | // wrap |
||
| 233 | 1 | case 'wrap': |
|
| 234 | return $this->replace('<' . $args[0] . '>' . $this . '</' . $args[0] . '>'); |
||
| 235 | 1 | case 'unwrap': |
|
| 236 | return $this->parent->replace($this); |
||
| 237 | |||
| 238 | 1 | case 'str': |
|
| 239 | return new Str($this->text); |
||
| 240 | |||
| 241 | // heirarchy |
||
| 242 | 1 | case 'firstchild': |
|
| 243 | return $this->at('> *'); |
||
| 244 | 1 | case 'lastchild': |
|
| 245 | return $this->at('> *:last'); |
||
| 246 | 1 | case 'nextsibling': |
|
| 247 | return $this->at('+ *'); |
||
| 248 | 1 | case 'prevsibling': |
|
| 249 | return $this->at('./preceding-sibling::*[1]'); |
||
| 250 | 1 | case 'parent': |
|
| 251 | return $this->at('./..'); |
||
| 252 | 1 | case 'children': |
|
| 253 | 1 | case 'childnodes': |
|
| 254 | $nl = $this->search('./*'); |
||
| 255 | |||
| 256 | return isset($args[0]) ? $nl[$args[0]] : $nl; |
||
| 257 | 1 | case 'child': // including text/comment nodes |
|
| 258 | $nl = $this->search('./*|./text()|./comment()'); |
||
| 259 | |||
| 260 | return isset($args[0]) ? $nl[$args[0]] : $nl; |
||
| 261 | |||
| 262 | } |
||
| 263 | |||
| 264 | // $doc->spans[x] |
||
| 265 | 1 | if (\preg_match(TAGS_REGEX, $key, $m)) |
|
| 266 | { |
||
| 267 | return $this->find($m[1]); |
||
| 268 | } |
||
| 269 | 1 | if (\preg_match(TAG_REGEX, $key, $m)) |
|
| 270 | { |
||
| 271 | return $this->find($m[1], 0); |
||
| 272 | } |
||
| 273 | |||
| 274 | 1 | if (\preg_match('/(clean|trim|str)(.*)/', $key, $m) && isset($m[2])) |
|
| 275 | { |
||
| 276 | list($arg0, $arg1, $arg2) = $m; |
||
| 277 | |||
| 278 | return $this->$arg1($this->$arg2); |
||
| 279 | } |
||
| 280 | |||
| 281 | 1 | if (\in_array($key, ['dom','node','doc'])) { |
|
| 282 | return null; |
||
| 283 | } |
||
| 284 | |||
| 285 | 1 | if (!\preg_match(ATTRIBUTE_REGEX, $key, $m)) |
|
| 286 | { |
||
| 287 | \trigger_error('Unknown method or property: ' . $key, E_USER_WARNING); |
||
| 288 | } |
||
| 289 | 1 | if (!$this->node || $this->is_text) |
|
| 290 | { |
||
| 291 | return null; |
||
| 292 | } |
||
| 293 | |||
| 294 | 1 | return $this->node->getAttribute($key); |
|
| 295 | } |
||
| 296 | |||
| 297 | /** |
||
| 298 | * @param $key |
||
| 299 | * |
||
| 300 | * @return mixed |
||
| 301 | */ |
||
| 302 | 2 | public function __get($key) |
|
| 303 | { |
||
| 304 | 2 | return $this->$key(); |
|
| 305 | } |
||
| 306 | |||
| 307 | /** |
||
| 308 | * @param $name |
||
| 309 | * @param $value |
||
| 310 | */ |
||
| 311 | public function __set($name, $value) |
||
| 314 | } |
||
| 315 | |||
| 316 | /** |
||
| 317 | * @param $name |
||
| 318 | * |
||
| 319 | * @return bool |
||
| 320 | */ |
||
| 321 | public function __isset($name) |
||
| 324 | } |
||
| 325 | } |
||
| 326 |
Loading history...