Api::process() - Code Metrics - Inspection of "rpc collection processing" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac259b...1b10af )

by Dmitry

created 2017-04-27 09:39 UTC

Api::process() B

↳ Parent: Api

Complexity

Conditions	5
Paths	8

Size

Total Lines	31
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	31
ccs	0
cts	28
cp	0
rs	8.439
cc	5
eloc	19
nc	8
nop	2
crap	30

<?php

namespace Basis\Controllers;

use Basis\Filesystem;
use Basis\Runner;
use Exception;

class Api
{
    public function index(Runner $runner)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(!array_key_exists('rpc', $_REQUEST)) {
            return [
                'success' => false,
                'message' => 'No rpc defined',
            ];
        }
        $data = json_decode($_REQUEST['rpc']);

        if(!$data) {
            return [
                'success' => false,
                'message' => 'Invalid rpc format',
            ];
        }

        $request = is_array($data) ? $data : [$data];

        $response = [];
        foreach($request as $rpc) {
            $result = $this->process($runner, $rpc);
            if(property_exists($rpc, 'tid')) {
                $result['tid'] = $rpc->tid;
            }
            $response[] = $result;
        }
        return is_array($data) ? $response : $response[0];
    }

    private function process($runner, $rpc)
    {
        if(!property_exists($rpc, 'job')) {
            return [
                'success' => false,
                'message' => 'Invalid rpc format: no job',
            ];
        }

        if(!property_exists($rpc, 'params')) {
            return [
                'success' => false,
                'message' => 'Invalid rpc format: no params',
            ];
        }

        try {
            $params = is_object($rpc->params) ? get_object_vars($rpc->params) : [];
            return [
                'success' => true,
                'data' => $runner->dispatch($rpc->job, $params),
            ];

        } catch(Exception $e) {
            return [
                'success' => false,
                'message' => $e->getMessage(),
                'trace' => explode(PHP_EOL, $e->getTraceAsString()),
            ];
        }
    }
}


1			<?php
2
3			namespace Basis\Controllers;
4
5			use Basis\Filesystem;
6			use Basis\Runner;
7			use Exception;
8
9			class Api
10			{
11			public function index(Runner $runner)
			0 ignored issues – show Coding Style introduced 2017-04-18 22:24 UTC by Report Bug Copy Issue Report `index` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
12			{
13			if(!array_key_exists('rpc', $_REQUEST)) {
14			return [
15			'success' => false,
16			'message' => 'No rpc defined',
17			];
18			}
19			$data = json_decode($_REQUEST['rpc']);
20
21			if(!$data) {
22			return [
23			'success' => false,
24			'message' => 'Invalid rpc format',
25			];
26			}
27
28			$request = is_array($data) ? $data : [$data];
29
30			$response = [];
31			foreach($request as $rpc) {
32			$result = $this->process($runner, $rpc);
33			if(property_exists($rpc, 'tid')) {
34			$result['tid'] = $rpc->tid;
35			}
36			$response[] = $result;
37			}
38			return is_array($data) ? $response : $response[0];
39			}
40
41			private function process($runner, $rpc)
42			{
43			if(!property_exists($rpc, 'job')) {
44			return [
45			'success' => false,
46			'message' => 'Invalid rpc format: no job',
47			];
48			}
49
50			if(!property_exists($rpc, 'params')) {
51			return [
52			'success' => false,
53			'message' => 'Invalid rpc format: no params',
54			];
55			}
56
57			try {
58			$params = is_object($rpc->params) ? get_object_vars($rpc->params) : [];
59			return [
60			'success' => true,
61			'data' => $runner->dispatch($rpc->job, $params),
62			];
63
64			} catch(Exception $e) {
65			return [
66			'success' => false,
67			'message' => $e->getMessage(),
68			'trace' => explode(PHP_EOL, $e->getTraceAsString()),
69			];
70			}
71			}
72			}
73

basis-company / framework.php

Push — master ( ac259b...1b10af )

Api::process() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like