GuzzleProvider::register() - Code Metrics - Inspection of "testing dispatcher" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c85e73...41284f )

by Dmitry

created 2018-01-30 12:24 UTC

GuzzleProvider::register() A

↳ Parent: GuzzleProvider

Complexity

Conditions	3
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	17
ccs	0
cts	10
cp	0
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	10
nc	1
nop	0
crap	12

<?php

namespace Basis\Provider;

use GuzzleHttp\Client;
use League\Container\ServiceProvider\AbstractServiceProvider;

class GuzzleProvider extends AbstractServiceProvider
{
    protected $provides = [
        Client::class,
    ];

    public function register()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->getContainer()->share(Client::class, function () {
            $headers = [
                'transfer-encoding' => 'chunked',
            ];
            if (array_key_exists('HTTP_X_REAL_IP', $_SERVER)) {
                $headers['x-real-ip'] = $_SERVER['HTTP_X_REAL_IP'];
            }
            if (array_key_exists('HTTP_X_SESSION', $_SERVER)) {
                $headers['x-session'] = $_SERVER['HTTP_X_SESSION'];
            }
            return new Client([
                'headers' => $headers
            ]);
        });
    }
}


1			<?php
2
3			namespace Basis\Provider;
4
5			use GuzzleHttp\Client;
6			use League\Container\ServiceProvider\AbstractServiceProvider;
7
8			class GuzzleProvider extends AbstractServiceProvider
9			{
10			protected $provides = [
11			Client::class,
12			];
13
14			public function register()
			0 ignored issues – show Coding Style introduced 2018-01-30 12:27 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			{
16			$this->getContainer()->share(Client::class, function () {
17			$headers = [
18			'transfer-encoding' => 'chunked',
19			];
20			if (array_key_exists('HTTP_X_REAL_IP', $_SERVER)) {
21			$headers['x-real-ip'] = $_SERVER['HTTP_X_REAL_IP'];
22			}
23			if (array_key_exists('HTTP_X_SESSION', $_SERVER)) {
24			$headers['x-session'] = $_SERVER['HTTP_X_SESSION'];
25			}
26			return new Client([
27			'headers' => $headers
28			]);
29			});
30			}
31			}
32

basis-company / framework.php

Push — master ( c85e73...41284f )

GuzzleProvider::register() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like