Dispatcher::dispatch() - Code Metrics - Inspection of "testing dispatcher" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c85e73...41284f )

by Dmitry

created 2018-01-30 12:24 UTC

Dispatcher::dispatch() B

↳ Parent: Dispatcher

Complexity

Conditions	6
Paths	6

Size

Total Lines	31
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	6.0852

Importance

Changes

Metric	Value
dl	0
loc	31
ccs	13
cts	15
cp	0.8667
rs	8.439
c	0
b	0
f	0
cc	6
eloc	16
nc	6
nop	3
crap	6.0852

<?php

namespace Basis;

use Exception;
use GuzzleHttp\Client;

class Dispatcher
{
    public function __construct(Client $client)
    {
        $this->client = $client;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function dispatch(string $job, array $params = [], string $service = null)
    {
        if ($service === null) {
            $service = explode('.', $job)[0];
        }

        $response = $this->client->post("http://$service/api", [
            'multipart' => [
                [
                    'name' => 'rpc',
                    'contents' => json_encode([
                        'job'    => $job,
                        'params' => $params,
                    ])
                ]
            ]
        ]);

        $contents = $response->getBody();

        if (!$contents) {
            throw new Exception("Host $service unreachable");
        }

        $result = json_decode($contents);
        if (!$result || !$result->success) {
            throw new Exception($result->message ?: $contents);
        }

        return $result->data;
    }
}


1		<?php
2
3		namespace Basis;
4
5		use Exception;
6		use GuzzleHttp\Client;
7
8		class Dispatcher
9		{
10	1	public function __construct(Client $client)
11		{
12	1	$this->client = $client;
		0 ignored issues – show Bug introduced 2018-01-30 12:27 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13	1	}
14
15	1	public function dispatch(string $job, array $params = [], string $service = null)
16		{
17	1	if ($service === null) {
18	1	$service = explode('.', $job)[0];
19		}
20
21	1	$response = $this->client->post("http://$service/api", [
22		'multipart' => [
23		[
24	1	'name' => 'rpc',
25	1	'contents' => json_encode([
26	1	'job' => $job,
27	1	'params' => $params,
28		])
29		]
30		]
31		]);
32
33	1	$contents = $response->getBody();
34
35	1	if (!$contents) {
36		throw new Exception("Host $service unreachable");
37		}
38
39	1	$result = json_decode($contents);
40	1	if (!$result \|\| !$result->success) {
41		throw new Exception($result->message ?: $contents);
42		}
43
44	1	return $result->data;
45		}
46		}
47

basis-company / framework.php

Push — master ( c85e73...41284f )

Dispatcher::dispatch() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like