Mapper::find() - Code Metrics - Inspection of "test.mapper findOne shortcut" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 12cc86...f0fc0a )

by Dmitry

created 2018-02-27 11:11 UTC

Mapper::find() B

↳ Parent: Mapper

Complexity

Conditions	5
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5.025

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	9
cts	10
cp	0.9
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	3
nop	2
crap	5.025

<?php

namespace Basis\Test;

use Exception;

class Mapper
{
    protected $data;

    public function __construct($data)
    {
        $this->data = [];
        foreach ($data as $space => $rows) {
            $this->data[$space] = [];
            foreach ($rows as $row) {
                $this->data[$space][] = (object) $row;
            }
        }
    }

    public function find(string $space, $params = [])
    {
        if (array_key_exists($space, $this->data)) {
            $data = $this->data[$space];
            if (count($params)) {
                foreach ($data as $i => $v) {
                    if (array_intersect_assoc($params, get_object_vars($v)) != $params) {
                        unset($data[$i]);
                    }
                }
                $data = array_values($data);
            }
            return $data;
        }
        return [];
    }

    public function findOne(string $space, $params = [])
    {
        if (array_key_exists($space, $this->data)) {
            foreach ($this->data[$space] as $candidate) {
                if (!count($params) || array_intersect_assoc($params, get_object_vars($candidate)) == $params) {
                    return $candidate;
                }
            }
        }
    }

    public function findOrFail(string $space, $params = [])
    {
        $result = $this->findOne($space, $params);
        if (!$result) {
            throw new Exception("No ".$space.' found using '.json_encode($params));
        }
        return $result;
    }
}


1		<?php
2
3		namespace Basis\Test;
4
5		use Exception;
6
7		class Mapper
8		{
9		protected $data;
10
11	2	public function __construct($data)
12		{
13	2	$this->data = [];
14	2	foreach ($data as $space => $rows) {
15	2	$this->data[$space] = [];
16	2	foreach ($rows as $row) {
17	2	$this->data[$space][] = (object) $row;
18		}
19		}
20	2	}
21
22	1	public function find(string $space, $params = [])
23		{
24	1	if (array_key_exists($space, $this->data)) {
25	1	$data = $this->data[$space];
26	1	if (count($params)) {
27	1	foreach ($data as $i => $v) {
28	1	if (array_intersect_assoc($params, get_object_vars($v)) != $params) {
29	1	unset($data[$i]);
30		}
31		}
32	1	$data = array_values($data);
33		}
34	1	return $data;
35		}
36		return [];
37		}
38
39	1	public function findOne(string $space, $params = [])
40		{
41	1	if (array_key_exists($space, $this->data)) {
42	1	foreach ($this->data[$space] as $candidate) {
43	1	if (!count($params) \|\| array_intersect_assoc($params, get_object_vars($candidate)) == $params) {
44	1	return $candidate;
45		}
46		}
47		}
48	1	}
49
50	1	public function findOrFail(string $space, $params = [])
51		{
52	1	$result = $this->findOne($space, $params);
53	1	if (!$result) {
54	1	throw new Exception("No ".$space.' found using '.json_encode($params));
55		}
56	1	return $result;
57		}
58		}
59

basis-company / framework.php

Push — master ( 12cc86...f0fc0a )

Mapper::find() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like