CoreProvider - Code Metrics - Inspection of "share runner" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 43f223...184ac5 )

by Dmitry

created 2019-05-21 22:21 UTC

CoreProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	11.29 %

Coupling/Cohesion

Components	0
Dependencies	11

Test Coverage

Coverage

28.95%

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	11
dl	7
loc	62
ccs	11
cts	38
cp	0.2895
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	register()	7	48	1

How to fix Duplicated Code

<?php

namespace Basis\Provider;

use Basis\Application;
use Basis\Cache;
use Basis\Config;
use Basis\Context;
use Basis\Converter;
use Basis\Dispatcher;
use Basis\Runner;
use Basis\Filesystem;
use Basis\Framework;
use Basis\Http;
use Basis\Lock;
use Basis\Service;
use GuzzleHttp\Client as GuzzleHttpClient;
use League\Container\ServiceProvider\AbstractServiceProvider;
use Predis\Client as PredisClient;

class CoreProvider extends AbstractServiceProvider
{
    protected $provides = [
        Cache::class,
        Config::class,
        Converter::class,
        Dispatcher::class,
        Framework::class,
        Http::class,
        Lock::class,
        Runner::class,
    ];

    public function register()
    {
        $this->getContainer()->share(Config::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $app = $this->getContainer()->get(Application::class);
            $framework = $this->getContainer()->get(Framework::class);
            $fs = $this->getContainer()->get(Filesystem::class);
            $converter = $this->getContainer()->get(Converter::class);
            return new Config($app, $framework, $fs, $converter);
        });

        $this->getContainer()->share(Cache::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $fs = $this->getContainer()->get(Filesystem::class);
            $converter = $this->getContainer()->get(Converter::class);
            return new Cache($fs, $converter);
        });

        $this->getContainer()->share(Lock::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $redis = $this->getContainer()->get(PredisClient::class);
            return new Lock($redis);
        });

        $this->getContainer()->share(Converter::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Converter();
        });

        $this->getContainer()->share(Dispatcher::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $context = $this->getContainer()->get(Context::class);
            $client = $this->getContainer()->get(GuzzleHttpClient::class);
            $service = $this->getContainer()->get(Service::class);
            return new Dispatcher($client, $context, $service);
        });

        $this->getContainer()->share(Framework::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Framework($this->getContainer(), dirname(dirname(__DIR__)));

        });

        $this->getContainer()->share(Http::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Http($this->getContainer()->get(Application::class));
        });

        $this->getContainer()->share(Runner::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Runner($this->getContainer()->get(Application::class));
        });

        $this->getContainer()->share(Context::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Context($this->getContainer()->get(Application::class));

        });
    }
}


Push — master ( 43f223...184ac5 )

CoreProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Application;
6		use Basis\Cache;
7		use Basis\Config;
8		use Basis\Context;
9		use Basis\Converter;
10		use Basis\Dispatcher;
11		use Basis\Runner;
12		use Basis\Filesystem;
13		use Basis\Framework;
14		use Basis\Http;
15		use Basis\Lock;
16		use Basis\Service;
17		use GuzzleHttp\Client as GuzzleHttpClient;
18		use League\Container\ServiceProvider\AbstractServiceProvider;
19		use Predis\Client as PredisClient;
20
21		class CoreProvider extends AbstractServiceProvider
22		{
23		protected $provides = [
24		Cache::class,
25		Config::class,
26		Converter::class,
27		Dispatcher::class,
28		Framework::class,
29		Http::class,
30		Lock::class,
31		Runner::class,
32		];
33
34		public function register()
35		{
36	View Code Duplication	$this->getContainer()->share(Config::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history... Duplication introduced 2018-05-11 06:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		$app = $this->getContainer()->get(Application::class);
38		$framework = $this->getContainer()->get(Framework::class);
39		$fs = $this->getContainer()->get(Filesystem::class);

basis-company / framework.php

Push — master ( 43f223...184ac5 )

CoreProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like