Issues in Test.php - New Issues - Inspection of "test pool resolves valid mapper (not fake)" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95b8e4...b19727 )

by Dmitry

created 2018-06-19 11:16 UTC

src/Test.php (4 issues)

Labels

Bug 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Basis;

use Basis\Converter;
use Basis\Service;
use PHPUnit\Framework\TestCase;
use ReflectionProperty;
use Tarantool\Mapper\Mapper;
use Tarantool\Mapper\Pool;

abstract class Test extends TestCase
{
    use Toolkit;

    public $params = [];
    public $disableRemote = true;

    public $mocks = [];
    public $data = [];

    public function __construct()
    {
        parent::__construct();

        $this->app = new Test\Application($this);

        foreach ($this->mocks as [$method, $params, $result]) {
            $this->mock($method, $params)->willReturn($result);
        }

        $serviceData = [];
        foreach ($this->data as $space => $data) {
            [$service, $space] = explode('.', $space);
function someFunction() {
    $x = 5;
    echo $x;
}
            if (!array_key_exists($service, $serviceData)) {
function someFunction() {
    $x = 5;
    echo $x;
}
                $serviceData[$service] = [];
function someFunction() {
    $x = 5;
    echo $x;
}
            }
            $serviceData[$service][$space] = $data;
function someFunction() {
    $x = 5;
    echo $x;
}
        }

        $pool = $this->app->get(Pool::class);
        $property = new ReflectionProperty(Pool::class, 'resolvers');
        $property->setAccessible(true);
        $property->setValue($pool, []);

        $service = $this->app->get(Service::class)->getName();
        $pool->register($service, function() {
            return $this->app->get(Mapper::class);
        });

        $pool->registerResolver(function($service) use ($serviceData) {
            if (array_key_exists($service, $serviceData)) {
                return new Test\Mapper($this, $service);
            }
        });
    }

    public function setup()
    {
        $this->dispatch('tarantool.migrate');
    }

    public function tearDown()
    {
        $this->dispatch('tarantool.clear');
    }

    public $mockInstances = [];

    public function mock(string $job, array $params = [])
    {
        if (!array_key_exists($job, $this->mockInstances)) {
            $this->mockInstances[$job] = [];
        }

        $mock = new Test\Mock($this->get(Converter::class), $this, $params);

        $this->mockInstances[$job][] = $mock;

        return $mock;
    }
}


1		<?php
2
3		namespace Basis;
4
5		use Basis\Converter;
6		use Basis\Service;
7		use PHPUnit\Framework\TestCase;
8		use ReflectionProperty;
9		use Tarantool\Mapper\Mapper;
10		use Tarantool\Mapper\Pool;
11
12		abstract class Test extends TestCase
13		{
14		use Toolkit;
15
16		public $params = [];
17		public $disableRemote = true;
18
19		public $mocks = [];
20		public $data = [];
21
22	3	public function __construct()
23		{
24		parent::__construct();
25
26		$this->app = new Test\Application($this);
27
28		foreach ($this->mocks as [$method, $params, $result]) {
29		$this->mock($method, $params)->willReturn($result);
30		}
31
32		$serviceData = [];
33		foreach ($this->data as $space => $data) {
34		[$service, $space] = explode('.', $space);
		0 ignored issues – show Bug introduced 2018-06-19 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$service` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
35		if (!array_key_exists($service, $serviceData)) {
		0 ignored issues – show Bug introduced 2018-06-19 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$service` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
36		$serviceData[$service] = [];
		0 ignored issues – show Bug introduced 2018-06-19 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$service` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
37		}
38		$serviceData[$service][$space] = $data;
		0 ignored issues – show Bug introduced 2018-06-19 11:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$service` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
39		}
40
41		$pool = $this->app->get(Pool::class);
42		$property = new ReflectionProperty(Pool::class, 'resolvers');
43		$property->setAccessible(true);
44		$property->setValue($pool, []);
45
46		$service = $this->app->get(Service::class)->getName();
47		$pool->register($service, function() {
48		return $this->app->get(Mapper::class);
49		});
50
51	3	$pool->registerResolver(function($service) use ($serviceData) {
52	3	if (array_key_exists($service, $serviceData)) {
53	2	return new Test\Mapper($this, $service);
54		}
55	2	});
56		}
57
58	45	public function setup()
59		{
60	45	$this->dispatch('tarantool.migrate');
61	45	}
62
63	45	public function tearDown()
64		{
65	45	$this->dispatch('tarantool.clear');
66	45	}
67
68		public $mockInstances = [];
69
70	5	public function mock(string $job, array $params = [])
71		{
72	5	if (!array_key_exists($job, $this->mockInstances)) {
73	4	$this->mockInstances[$job] = [];
74		}
75
76	5	$mock = new Test\Mock($this->get(Converter::class), $this, $params);
77
78	5	$this->mockInstances[$job][] = $mock;
79
80	5	return $mock;
81		}
82		}
83

basis-company / framework.php

Push — master ( 95b8e4...b19727 )

src/Test.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like