Basis\Service

Complexity

Total Complexity

15

Size/Duplication

Total Lines	98
Duplicated Lines	39.8 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	eventExists()	0	4	1
A	getName()	0	4	1
A	registerJob()	0	5	1
A	subscribe()	0	4	1
A	unsibscribe()	0	4	1
A	exists()	0	16	2
A	store()	20	20	3
A	remove()	19	19	3

<?php

namespace Basis;

use Exception;
use LinkORB\Component\Etcd\Client;

class Service
{
    private $client;
    private $name;

    public function __construct(Client $client, Config $config)
    {
        $this->client = $client;
        $this->name = $config['service'];
        if(!$this->name) {
            throw new Exception("No service defined in config");
        }
    }

    public function eventExists($event)
    {
        return $this->exists("events/$event");
    }

    public function getName()
    {
        return $this->name;
    }

    public function registerJob($job, $params)
    {
        $this->store("jobs/$job/params", json_encode($params));
        $this->store("jobs/$job/service", $this->name);
    }

    public function subscribe($event)
    {
        $this->store("events/$event/$this->name");
    }

    public function unsibscribe($event)
    {
        $this->remove("events/$event/$this->name");
    }

    private function exists($path)
    {
        $chain = explode('/', $path);
        $key = array_pop($chain);
        $folder = implode('/', $chain);

        try {
            $this->client->setRoot($folder);
            $this->client->get($key);

        } catch(Exception $e) {
            return false;
        }

        return true;
    }

    private function store($path, $value = null)

This method seems to be duplicated in your project.

    {
        $chain = explode('/', $path);

        $key = array_pop($chain);
        $folder = implode('/', $chain);

        $this->client->setRoot($folder);
        try {
            $this->client->ls('.');
        } catch(Exception $e) {
            $this->client->mkdir('.');
        }

        try {
            $this->client->get($key);
        } catch(Exception $e) {
            $this->client->set($key, $value);
        }
    }

    private function remove($path)

This method seems to be duplicated in your project.

    {
        $chain = explode('/', $path);

        $key = array_pop($chain);
        $folder = implode('/', $chain);

        $this->client->setRoot($folder);
        try {
            $this->client->ls('.');
        } catch(Exception $e) {
            $this->client->mkdir('.');
        }

        try {
            $this->client->remove($key);

The method remove() does not seem to exist on object<LinkORB\Component\Etcd\Client>.

        } catch(Exception $e) {

Consider adding a comment why this CATCH block is empty.

        }
    }
}