CoreProvider - Code Metrics - Inspection of "upgrade phpunit version" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7430fb...df39a0 )

by Dmitry

created 2019-11-22 16:42 UTC

CoreProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	11

Test Coverage

Coverage

21.43%

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	11
dl	0
loc	60
ccs	6
cts	28
cp	0.2143
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	register()	0	46	1

<?php

namespace Basis\Provider;

use Basis\Application;
use Basis\Cache;
use Basis\Config;
use Basis\Context;
use Basis\Converter;
use Basis\Dispatcher;
use Basis\Runner;
use Basis\Filesystem;
use Basis\Framework;
use Basis\Http;
use Basis\Lock;
use Basis\Service;
use GuzzleHttp\Client as GuzzleHttpClient;
use League\Container\ServiceProvider\AbstractServiceProvider;
use Predis\Client as PredisClient;

class CoreProvider extends AbstractServiceProvider
{
    protected $provides = [
        Cache::class,
        Config::class,
        Converter::class,
        Dispatcher::class,
        Framework::class,
        Http::class,
        Lock::class,
        Runner::class,
    ];

    public function register()
    {
        $this->getContainer()->share(Config::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $app = $this->getContainer()->get(Application::class);
            $framework = $this->getContainer()->get(Framework::class);
            $fs = $this->getContainer()->get(Filesystem::class);
            $converter = $this->getContainer()->get(Converter::class);
            return new Config($app, $framework, $fs, $converter);
        });

        $this->getContainer()->share(Cache::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $fs = $this->getContainer()->get(Filesystem::class);
            $converter = $this->getContainer()->get(Converter::class);
            return new Cache($fs, $converter);
        });

        $this->getContainer()->share(Lock::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $redis = $this->getContainer()->get(PredisClient::class);
            return new Lock($redis);
        });

        $this->getContainer()->share(Converter::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Converter();
        });

        $this->getContainer()->share(Dispatcher::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $app = $this->getContainer()->get(Application::class);
            return new Dispatcher($app);
        });

        $this->getContainer()->share(Framework::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Framework($this->getContainer(), dirname(dirname(__DIR__)));

        });

        $this->getContainer()->share(Http::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Http($this->getContainer()->get(Application::class));
        });

        $this->getContainer()->share(Runner::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Runner($this->getContainer()->get(Application::class));
        });

        $this->getContainer()->share(Context::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Context($this->getContainer()->get(Application::class));

        });
    }
}


Push — master ( 7430fb...df39a0 )

CoreProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Application;
6		use Basis\Cache;
7		use Basis\Config;
8		use Basis\Context;
9		use Basis\Converter;
10		use Basis\Dispatcher;
11		use Basis\Runner;
12		use Basis\Filesystem;
13		use Basis\Framework;
14		use Basis\Http;
15		use Basis\Lock;
16		use Basis\Service;
17		use GuzzleHttp\Client as GuzzleHttpClient;
18		use League\Container\ServiceProvider\AbstractServiceProvider;
19		use Predis\Client as PredisClient;
20
21		class CoreProvider extends AbstractServiceProvider
22		{
23		protected $provides = [
24		Cache::class,
25		Config::class,
26		Converter::class,
27		Dispatcher::class,
28		Framework::class,
29		Http::class,
30		Lock::class,
31		Runner::class,
32		];
33
34	52	public function register()
35		{
36		$this->getContainer()->share(Config::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37		$app = $this->getContainer()->get(Application::class);
38		$framework = $this->getContainer()->get(Framework::class);
39		$fs = $this->getContainer()->get(Filesystem::class);
40		$converter = $this->getContainer()->get(Converter::class);
41		return new Config($app, $framework, $fs, $converter);
42		});
43
44		$this->getContainer()->share(Cache::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45		$fs = $this->getContainer()->get(Filesystem::class);
46		$converter = $this->getContainer()->get(Converter::class);
47		return new Cache($fs, $converter);
48		});
49
50		$this->getContainer()->share(Lock::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51		$redis = $this->getContainer()->get(PredisClient::class);
52		return new Lock($redis);
53		});
54
55		$this->getContainer()->share(Converter::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56		return new Converter();
57		});
58
59		$this->getContainer()->share(Dispatcher::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
60	52	$app = $this->getContainer()->get(Application::class);
61	52	return new Dispatcher($app);
62		});
63
64		$this->getContainer()->share(Framework::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
65		return new Framework($this->getContainer(), dirname(dirname(__DIR__)));
		0 ignored issues – show Compatibility introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report `$this->getContainer()` of type `object<Psr\Container\ContainerInterface>` is not a sub-type of `object<Basis\Application>`. It seems like you assume a concrete implementation of the interface `Psr\Container\ContainerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
66		});
67
68		$this->getContainer()->share(Http::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69	3	return new Http($this->getContainer()->get(Application::class));
70		});
71
72		$this->getContainer()->share(Runner::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
73	52	return new Runner($this->getContainer()->get(Application::class));
74		});
75
76		$this->getContainer()->share(Context::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 22:24 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
77	2	return new Context($this->getContainer()->get(Application::class));
		0 ignored issues – show Unused Code introduced 2018-08-07 23:00 UTC by Report Bug Copy Issue Report The call to `Context::__construct()` has too many arguments starting with `$this->getContainer()->g...sis\Application::class)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
78		});
79		}
80		}
81

basis-company / framework.php

Push — master ( 7430fb...df39a0 )

CoreProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like